NA support in frollmax #7
Conversation
Co-authored-by: Marco Colombo <[email protected]>
Co-authored-by: Benjamin Schwendinger <[email protected]>
| adaptive = TRUE | ||
| } | ||
| if (isTRUE(adaptive) && base::getRversion() < "3.4.0") ## support SET_GROWABLE_BIT | ||
| stopf("frollapply adaptive=TRUE requires at least R 3.4.0"); # nocov |
There was a problem hiding this comment.
let's just bump to 3.4.0 dependency for 1.18.0: Rdatatable#6840
There was a problem hiding this comment.
this will be rewritten in Rdatatable#5575 and then it will also work on < 3.4.0 but with an extra copy on each iteration.
| rev2 = function(x) if (is.list(x)) lapply(x, rev) else rev(x) | ||
| if (verbose) | ||
| cat("froll: adaptive=TRUE && align='left' pre-processing for align='right'\n") | ||
| cat("frollapply: adaptive=TRUE && align='left' pre-processing for align='right'\n") |
There was a problem hiding this comment.
| cat("frollapply: adaptive=TRUE && align='left' pre-processing for align='right'\n") | |
| catf("frollapply: adaptive=TRUE && align='left' pre-processing for align='right'\n") |
There was a problem hiding this comment.
There are multiple places for updates like that. As I move forward with next PRs on each one there is more and more conflicts to resolve, conflicts accumulates. Therefore to avoid more conflicts for next PRs I will put it on a list of follow up things to do, once all PRs are in.
| } | ||
| } | ||
| } | ||
| static inline void windowmaxnarm(const double * restrict x, uint64_t o, int k, bool narm, int *nc, double * restrict w, uint64_t *iw) { |
There was a problem hiding this comment.
static that was lost here, due to auto resolving conflicts, will be added in froll2025max8, where it was originally included
NA handling in frollmax added
frollmax code reorg
more tests coming