Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

Conversation

@luke-nguyen990
Copy link
Contributor

@luke-nguyen990 luke-nguyen990 commented Nov 13, 2024

Describe Your Changes

Running Cortex in the foreground provides developers with an additional tool for debugging and helps newcomers learn the flow. This ticket aims to support running Cortex in the foreground without disrupting the current workflow.

cortex start --foreground
Screenshot 2024-11-13 at 09 05 56

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@luke-nguyen990 luke-nguyen990 marked this pull request as ready for review November 13, 2024 02:19
Copy link
Contributor

@dan-menlo dan-menlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gabrielle-ong
Copy link
Contributor

@dan-homebrew @luke-nguyen990
This will depends on our decision for #1672

@luke-nguyen990
Copy link
Contributor Author

luke-nguyen990 commented Nov 13, 2024

@dan-homebrew @luke-nguyen990 This will depends on our decision for #1672

@dan-homebrew @luke-nguyen990 This will depends on our decision for #1672

I want to explore and onboard myself more deeply here.
Before writing the code above, I already looked at the flow for log.

  • The current discussion seems to be about the approach and design for log streaming to files.
  • For this PR, I created a feature for log in the terminal specifically for optimizing local development, i.e developers can just use a simple cout << for debugging.

@luke-nguyen990 luke-nguyen990 marked this pull request as draft November 18, 2024 01:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants