refactor: replace LocalOAIEngine with LocalAIEngine #6988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate the legacy `LocalOAIEngine` abstraction to a new, generic `LocalAIEngine` base. - Move all OpenAI type definitions to `LocalAIEngineTypes` and expose them via the engine index. - Remove the old `LocalOAIEngine` files (and its test) and replace them with `LocalAIEngine` that defines the abstract API for local inference providers. - Update the `llamacpp-extension` to extend `LocalAIEngine` instead of `AIEngine`. - Adjust exports to include the new engine and types, and clean up unused imports. - Add a new test suite for `LocalAIEngine` ensuring the abstract contract is satisfied.
Contributor
Barecheck - Code coverage reportTotal: 30.03%Your code coverage diff: -0.02% ▾ ✅ All code changes are covered |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Migrate the legacy
LocalOAIEngineabstraction to a new, genericLocalAIEnginebase.LocalAIEngineTypesand expose them via the engine index.LocalOAIEnginefiles (and its test) and replace them withLocalAIEnginethat defines the abstract API for local inference providers.llamacpp-extensionto extendLocalAIEngineinstead ofAIEngine.LocalAIEngineensuring the abstract contract is satisfied.Fixes Issues
Self Checklist