refactor: move llama.cpp config handling to Rust #7000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Barecheck - Code coverage reportTotal: 30.06%Your code coverage diff: 0.00% ▴ ✅ All code changes are covered |
louis-jan
reviewed
Nov 18, 2025
louis-jan
reviewed
Nov 18, 2025
louis-jan
reviewed
Nov 18, 2025
- Removed duplicated TypeScript type definitions for LlamacppConfig, ModelPlan, DownloadItem, ModelConfig, etc. - Added a new `src/guest-js/types.ts` that exports the consolidated types and a helper `normalizeLlamacppConfig` for converting raw config objects. - Implemented a dedicated Rust module `args.rs` that builds all command‑line arguments for llama.cpp from a `LlamacppConfig` struct, handling embedding, flash‑attention, GPU/CPU flags, and other options. - Updated `commands.rs` to construct arguments via `ArgumentBuilder`, validate paths, and log the generated args. - Added more explicit error handling for invalid configuration arguments and updated the error enum to include `InvalidArgument`. - Exported the new `cleanupLlamaProcesses` command and updated the guest‑JS API accordingly. - Adjusted the TypeScript `loadLlamaModel` helper to use the new config normalization and argument shape. - Improved logging and documentation for clarity.
Prevent adding the `--mmproj` flag when the provided path string is empty. An empty `mmproj_path` previously caused an empty argument to be passed to the model loader, potentially leading to errors or undefined behavior. By filtering out empty strings before pushing the flag, the command line construction is now robust against malformed input.
Use `String::new()` instead of `“”.to_string()` when no API key is supplied. This eliminates an unnecessary heap allocation and clarifies that the intent is to create an empty string without creating a temporary literal.
qnixsynapse
force-pushed
the
chore/argument_handler
branch
from
a92ef97 to
997efdd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
src/guest-js/types.tsthat exports the consolidated types and a helpernormalizeLlamacppConfigfor converting raw config objects.args.rsthat builds all command‑line arguments for llama.cpp from aLlamacppConfigstruct, handling embedding, flash‑attention, GPU/CPU flags, and other options.commands.rsto construct arguments viaArgumentBuilder, validate paths, and log the generated args.InvalidArgument.cleanupLlamaProcessescommand and updated the guest‑JS API accordingly.loadLlamaModelhelper to use the new config normalization and argument shape.Fixes Issues
Self Checklist