fix: disable auto fit setting by default#7610
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes the default value of the fit (auto-fit) setting in the llamacpp extension from true to false across all platforms. Previously, fit was enabled by default everywhere except macOS, which had a dedicated code path to override it to false. This PR makes the behavior consistent and "opt-in" by disabling it globally and removing the platform-specific override code.
Changes:
- Default value for
fitinsettings.jsonchanged fromtruetofalse - Removed the macOS-specific
if (IS_MAC)block that overrodefittofalseat runtime - Minor whitespace formatting fix on the
cfg.fitmigration line (if(→if ()
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
extensions/llamacpp-extension/settings.json |
Sets the default fit checkbox value to false instead of true |
extensions/llamacpp-extension/src/index.ts |
Removes the macOS-only fit override block; fixes whitespace on the migration check |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Barecheck - Code coverage reportTotal: 22.25%Your code coverage diff: 0.00% ▴ ✅ All code changes are covered |
urmauur
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Disable
fitfeature in favor of #7609fit(auto-fit) setting fromtruetofalseinsettings.jsonfiton Mac —fitis now disabled by default on all platformscfg.fitmigration checkMotivation
Previously,
fitwas enabled by default on all platforms except macOS, which had a special code path to override it tofalse. This was inconsistent. Disabling it globally by default is the safer behavior: users who want auto-fitting can opt in explicitly.Test plan
fitenabledfiton manually and confirm it applies correctlyfalsethere)