Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a UI entry point in the Settings sidebar to create new (OpenAI-compatible) model providers, so users can add providers without navigating to the dedicated Model Providers page.
Changes:
- Adds an “Add Provider” action to the Settings menu’s Model Providers section via
AddProviderDialog. - Introduces
createProviderlogic inSettingsMenuto create and persist a new provider, then navigate to its settings page. - Defaults the providers section expansion state to expanded.
Comments suppressed due to low confidence (1)
web-app/src/containers/SettingsMenu.tsx:46
setTimeout(..., 0)around the navigation looks unnecessary here becauseaddProvider(Zustandset) is synchronous. Prefer navigating immediately afteraddProvider(or, if a deferral is required, use a documented approach likequeueMicrotask/requestAnimationFrame) to avoid leaving an untracked timer running if the component unmounts quickly.
addProvider(newProvider)
setTimeout(() => {
navigate({ to: route.settings.providers, params: { providerName: name } })
}, 0)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
web-app/src/containers/tests/SettingsMenu.test.tsx:130
- The test selects the chevron via
getAllByRole('button')[0], but the menu now renders multiple buttons (e.g., the new “Add Provider” button). This makes the test dependent on DOM ordering. Consider scoping the query to the Model Providers row/link and selecting the nested button from there so the test remains stable if more buttons are added later.
// Click the chevron to collapse
const chevronButtons = screen.getAllByRole('button')
const chevron = chevronButtons[0]
await user.click(chevron)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
louis-jan
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Fixes Issues
Self Checklist