chore: add notarization step for mac #188
Merged
+56
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qnixsynapse
approved these changes
Aug 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for notarizing macOS binaries in the build process. The changes include updates to the GitHub Actions workflow, the
Makefile, and the addition of a newnotarizetarget to handle notarization logic. These updates ensure that macOS binaries are signed and notarized for enhanced security and compliance with macOS requirements.GitHub Actions Workflow Updates for Notarization:
.github/workflows/menlo-build.yml: Added steps to install Quill, prepare the notary key, notarize macOS binaries, and clean up the notary key. These steps are conditional on the runner's operating system being macOS.Updates to
Makefilefor Notarization:Makefile: Introduced new configuration variables (NOTARIZE,QUILL_NOTARY_KEY_ID,QUILL_NOTARY_ISSUER,QUILL_NOTARY_KEY) to support notarization. Default values are provided.Makefile: Added a newnotarizetarget to handle notarization logic. The target skips notarization for non-macOS platforms and performs notarization for macOS binaries using Quill.