Skip to content

Conversation

@vansangpfiev
Copy link

This pull request includes a small but important update to the Makefile. The change ensures that the codesign command targets the correct directory for signing binaries on Linux.

  • Makefile: Updated the codesign command to target the build/bin directory instead of the llama directory, ensuring the correct files are signed.

@Minh141120 Minh141120 self-requested a review May 12, 2025 09:34
Copy link
Member

@Minh141120 Minh141120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vansangpfiev vansangpfiev merged commit a3dcbb1 into dev May 12, 2025
12 of 28 checks passed
@vansangpfiev vansangpfiev deleted the s/fix/codesign-macos branch May 12, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants