Add CopyToClipboardButton component to browse and edit schemas #331
Conversation
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. 📝 WalkthroughWalkthroughAdds a new CopyToClipboardButton component to browse and edit-new schemas (componentNames, component modules, and component indexes), updates test fixtures/expected outputs, and removes a previously added CopyToClipboardButton alias and component creation from common actions/field.js. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (10)
lib/schemas/browse/modules/componentNames.js(1 hunks)lib/schemas/browse/modules/components/copyToClipboardButton.js(1 hunks)lib/schemas/browse/modules/components/index.js(2 hunks)lib/schemas/edit-new/modules/componentNames.js(1 hunks)lib/schemas/edit-new/modules/components/copyToClipboardButton.js(1 hunks)lib/schemas/edit-new/modules/components/index.js(2 hunks)tests/mocks/schemas/browse.json(1 hunks)tests/mocks/schemas/edit.yml(1 hunks)tests/mocks/schemas/expected/browse.json(1 hunks)tests/mocks/schemas/expected/edit.json(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.js
⚙️ CodeRabbit configuration file
Never report errors of the following categories
lint/suspicious/noRedundantUseStrict,lint/complexity/noThisInStatic,lint/complexity/noStaticOnlyClass, reported by Biome.
Files:
lib/schemas/browse/modules/components/index.jslib/schemas/edit-new/modules/components/copyToClipboardButton.jslib/schemas/edit-new/modules/components/index.jslib/schemas/edit-new/modules/componentNames.jslib/schemas/browse/modules/componentNames.jslib/schemas/browse/modules/components/copyToClipboardButton.js
🧬 Code graph analysis (2)
lib/schemas/browse/modules/components/index.js (2)
lib/schemas/edit-new/modules/components/index.js (2)
copyToClipboardButton(28-28)require(3-3)lib/schemas/common-components/index.js (1)
location(4-4)
lib/schemas/edit-new/modules/components/index.js (1)
lib/schemas/browse/modules/components/index.js (2)
copyToClipboardButton(18-18)require(3-3)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Cursor Bugbot
🔇 Additional comments (8)
lib/schemas/browse/modules/components/copyToClipboardButton.js (1)
1-9: LGTM! Clean component module structure.The implementation follows the established pattern for component modules in this codebase.
lib/schemas/browse/modules/components/index.js (2)
18-18: LGTM! Component import added correctly.The new copyToClipboardButton module is properly imported.
36-37: LGTM! Component export added correctly.The copyToClipboardButton is properly included in the exported components array.
tests/mocks/schemas/expected/edit.json (1)
606-610: Verify duplicate field name "name".This fieldsGroup now contains two fields both named "name" (one Select component at line 533 and this CopyToClipboardButton). Duplicate field names within the same fieldsGroup could cause data binding or validation issues.
Is this intentional for testing purposes, or should the CopyToClipboardButton use a different field name (e.g., "copyableName")?
tests/mocks/schemas/edit.yml (1)
372-374: Verify duplicate field name "name".Same concern as in the expected output: this creates a second field named "name" in the same fieldsGroup (the first is the Select at line 330). Consider using a unique field name if duplicate names could cause issues.
lib/schemas/edit-new/modules/components/index.js (2)
28-28: LGTM! Component import added correctly.The copyToClipboardButton module is properly imported.
54-54: LGTM! Component export added correctly.The copyToClipboardButton is properly included in the exported components array.
lib/schemas/edit-new/modules/components/copyToClipboardButton.js (1)
1-9: LGTM! Clean component module structure.The implementation correctly follows the established pattern. Note that line 4 will need to be updated when the naming inconsistency in
componentNames.jsis fixed (changingcopyToClipBoardButtontocopyToClipboardButton).
| countDown: 'CountDown', | ||
| location: 'Location' | ||
| location: 'Location', | ||
| copyToClipBoardButton: 'CopyToClipboardButton' |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| fieldList: 'FieldList', | ||
| steps: 'Steps' | ||
| steps: 'Steps', | ||
| copyToClipBoardButton: 'CopyToClipboardButton' |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
lib/schemas/common/actions/field.js
Outdated
| const componentNames = { | ||
| ...browseComponentNames, | ||
| copyToClipBoardButton: 'CopyToClipboardButton' | ||
| CopyToClipboardButton: 'CopyToClipboardButton' |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
lib/schemas/common/actions/field.js (1)
19-45: Avoid redundantCopyToClipboardButtondefinitions in actions schema
browseComponentsalready exports aCopyToClipboardButtoncomponent built withmakeComponent, andbrowseComponentNamesalready exposes'CopyToClipboardButton'in its values. The extramakeComponent({ name: 'CopyToClipboardButton', properties: {} })incomponentsand the explicitCopyToClipboardButtonentry incomponentNamesare therefore redundant and could drift from the base definition in future.You can simplify and keep a single source of truth like this:
const components = [ ...filteredBrowseComponents, makeComponent({ name: 'FieldList', @@ - requiredProperties: ['direction', 'fields'] - }), - makeComponent({ name: 'CopyToClipboardButton', properties: {} }) + requiredProperties: ['direction', 'fields'] + }) ]; -const componentNames = { - ...browseComponentNames, - CopyToClipboardButton: 'CopyToClipboardButton' -}; +const componentNames = browseComponentNames;This keeps the behavior the same today while reducing duplication and future maintenance risk.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
lib/schemas/browse/modules/componentNames.js(1 hunks)lib/schemas/browse/modules/components/copyToClipboardButton.js(1 hunks)lib/schemas/common/actions/field.js(1 hunks)lib/schemas/edit-new/modules/componentNames.js(1 hunks)lib/schemas/edit-new/modules/components/copyToClipboardButton.js(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- lib/schemas/browse/modules/components/copyToClipboardButton.js
🧰 Additional context used
📓 Path-based instructions (1)
**/*.js
⚙️ CodeRabbit configuration file
Never report errors of the following categories
lint/suspicious/noRedundantUseStrict,lint/complexity/noThisInStatic,lint/complexity/noStaticOnlyClass, reported by Biome.
Files:
lib/schemas/edit-new/modules/components/copyToClipboardButton.jslib/schemas/common/actions/field.jslib/schemas/edit-new/modules/componentNames.jslib/schemas/browse/modules/componentNames.js
🧬 Code graph analysis (1)
lib/schemas/edit-new/modules/components/copyToClipboardButton.js (2)
lib/schemas/browse/modules/components/copyToClipboardButton.js (2)
require(3-3)require(4-4)lib/schemas/utils.js (1)
makeComponent(13-37)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Cursor Bugbot
🔇 Additional comments (3)
lib/schemas/browse/modules/componentNames.js (1)
29-30: Browse component name wiring forCopyToClipboardButtonlooks goodThe new
CopyToClipboardButton: 'CopyToClipboardButton'entry aligns with how the browse component module destructures this constant and ensures the value is available in browse schemas. No issues here.lib/schemas/edit-new/modules/componentNames.js (1)
38-39: Edit-new component name mapping forCopyToClipboardButtonis consistentThe
CopyToClipboardButton: 'CopyToClipboardButton'entry matches howcomponents/copyToClipboardButton.jsimports this constant and ensures the value is part of the edit-new component enum. Looks correct.lib/schemas/edit-new/modules/components/copyToClipboardButton.js (1)
1-9:CopyToClipboardButtoncomponent wiring for edit-new is correctThis module cleanly reuses
makeComponentwith theCopyToClipboardButtonname fromcomponentNames, giving edit-new schemas a validcomponentAttributescontract (empty, with no extra props). No problems spotted.
dgiannico19
changed the title
Link al ticket
Descripción del requerimiento
Descripción de la solución
Cómo se puede probar?
npm run testResultado esperado
Todos los test corren perfectamente
Changelog
Note
Adds
CopyToClipboardButtonto browse and edit schemas and updates tests to cover it.CopyToClipboardButtoninlib/schemas/browse/modules/componentNames.jsand include incomponents/index.js.components/copyToClipboardButton.js.CopyToClipboardButtoninlib/schemas/edit-new/modules/componentNames.jsand include incomponents/index.js.components/copyToClipboardButton.js.CopyToClipboardButtonentry fromlib/schemas/common/actions/field.js; rely on shared browse component names.tests/mocks/schemas/browse.jsonandedit.ymlto useCopyToClipboardButton.tests/mocks/schemas/expected/browse.jsonandexpected/edit.json.Written by Cursor Bugbot for commit fe86a27. This will update automatically on new commits. Configure here.
Summary by CodeRabbit
New Features
Tests
Bug Fixes
Refactor
✏️ Tip: You can customize this high-level summary in your review settings.