Convert thrown? clauses to handle CLJS and Clojure JVM#43
Merged
jeaye merged 1 commit intojank-lang:mainfrom Jan 18, 2025
Merged
Convert thrown? clauses to handle CLJS and Clojure JVM#43jeaye merged 1 commit intojank-lang:mainfrom
thrown? clauses to handle CLJS and Clojure JVM#43jeaye merged 1 commit intojank-lang:mainfrom
Conversation
NoahTheDuke
reviewed
Jan 18, 2025
|
|
||
| (is #?@(:cljs [(= false (zero? nil))] | ||
| :default [(thrown? Exception (zero? nil))])) | ||
| :default [(thrown? #?(:cljs :default :default Exception) (zero? nil))])) |
Member
There was a problem hiding this comment.
Nope, but this conversion was automated. I saw it during the review, as well, but didn't think it was worth more iteration.
Contributor
Author
There was a problem hiding this comment.
Yea, I'm going through and catching some of those by hand. I'll try to do a deeper, file-by-file pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This converts
(is (thrown? Exception ...))clauses to(is (thrown? #?(:cljs :default :default Exception) ...))to properly catch any sort of Javascript exception in Clojurescript.