Rename 'singlequote' to 'tick' in test file names#46
Rename 'singlequote' to 'tick' in test file names#46dgr wants to merge 1 commit intojank-lang:mainfrom
Conversation
For brevity.
|
Clojure uses I'd prefer to keep this Clojurestatic final public IPersistentMap CHAR_MAP =
PersistentHashMap.create('-', "_",
// '.', "_DOT_",
':', "_COLON_",
'+', "_PLUS_",
'>', "_GT_",
'<', "_LT_",
'=', "_EQ_",
'~', "_TILDE_",
'!', "_BANG_",
'@', "_CIRCA_",
'#', "_SHARP_",
'\'', "_SINGLEQUOTE_",
'"', "_DOUBLEQUOTE_",
'%', "_PERCENT_",
'^', "_CARET_",
'&', "_AMPERSAND_",
'*', "_STAR_",
'|', "_BAR_",
'{', "_LBRACE_",
'}', "_RBRACE_",
'[', "_LBRACK_",
']', "_RBRACK_",
'/', "_SLASH_",
'\\', "_BSLASH_",
'?', "_QMARK_");jank static native_unordered_map<char, native_persistent_string_view> const munge_chars{
{ '-', "_" },
{ ':', "_COLON_" },
{ '+', "_PLUS_" },
{ '>', "_GT_" },
{ '<', "_LT_" },
{ '=', "_EQ_" },
{ '~', "_TILDE_" },
{ '!', "_BANG_" },
{ '@', "_CIRCA_" },
{ '#', "_SHARP_" },
{ '\'', "_SQUOTE_" },
{ '"', "_DQUOTE_" },
{ '%', "_PERC_" },
{ '^', "_CARET_" },
{ '&', "_AMP_" },
{ '*', "_STAR_" },
{ '|', "_BAR_" },
{ '{', "_LBRACE_" },
{ '}', "_RBRACE_" },
{ '[', "_LBRACK_" },
{ ']', "_RBRACK_" },
{ '/', "_SLASH_" },
{ '\\', "_BSLASH_" },
{ '?', "_QMARK_" }
};
|
|
Nah, thought about this a bit more. Clojure's munges are too long. Let's be consistent with jank, though. I'd rather have two standards than three. That means |
|
OK, I can update to "squote" and "qmark". Yea, I was just looking for shorter names overall. Tick is used a lot in Forth. I'll update the Babashka |
|
I notice that the dollar sign is not in either of those lists. I have it as mapping to "dollar". Is that good, or do we want something else? |
No need for you to map that. Dollar sign doesn't exist in Clojure vars, since it's used to indicate nested Java classes. |
|
I'm going to close this and do the rename of the files in the Babashka tasks PR. |
For brevity.