Run each implementation's tests in separate Github Actions steps#841
Conversation
.github/workflows/ci.yml
Outdated
| on: | ||
| pull_request: | ||
| branches: [main] | ||
| types: [ opened, synchronize, reopened ] |
There was a problem hiding this comment.
Run on all PRs, rather than only main. I was wondering if perhaps you elected not to do this since it would use your org's actions budget.
There was a problem hiding this comment.
Nah, this is free for us. Is there a benefit to specifying these types vs the default types for pull_request?
There was a problem hiding this comment.
I had copied this from my own actions which I pulled from some other actions definition years ago, so I was just blindly copying 😅
Seems like these are the defaults for pull_request. I'll remove them.
.github/workflows/ci.yml
Outdated
| dotnet tool install --global Clojure.Main --version 1.12.3-alpha4 | ||
| dotnet tool install --global Clojure.Cljr --version 0.1.0-alpha6 | ||
| - name: Run babashka tests | ||
| run: bb test-bb |
There was a problem hiding this comment.
Why are we running Babashka tests here?
There was a problem hiding this comment.
Missed this during cleanup. Thanks for pointing it out! Fixed in 9294bfe
|
Great work, Chris! |
3 participants
As I was working on #840 I realized that it isn't terribly easy to know when my changes might have affected other implementations, so I was hoping to have a feedback loop with CI. I split up each implementation into a separate Github Action step so they could all run in parallel and report back on the PR as a check. It's a bit duplicative right now because I just copied and pasted the different steps. There are ways to reduce that duplication, but I decided to err on the side of simplicity rather than attempting to over-engineer the YAML.
I had a mind to add some additional
bbtasks in another PR to make it easier to run all of the test suites locally as well, so do let me know if that might be worth doing. The trick there is that I use a Mac so I'm sure I wouldn't be able to configure the steps for setting up various different Clojure implementations across multiple different OSes.Just to note: this is just a suggestion to help improve the feedback loop for folks submitting, so let me know if this is actually not useful or preferred. Happy to close and continue with what was there if it was set up as such for a reason. Thanks!