You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @KevinZonda,
Thanks for your interest and this PR. You need to provide a bit more context here, ideally a test or MWE that fails with the old version and works with your fix. E.g., you're pointing to gijswobben/pymed#30 which updates article.py but your change is in book.py. When testing your code with the original query from the example, nothing changes, so I dont see any reason to merge the PR as is.
@KevinZonda I opened #7 to fix the issue you mention by changing article.py (rather than book.py). Let me know if you have any thoughts on this, otherwise #7 will be merged soon instead of this PR.
Thx for raising this issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refer to gijswobben/pymed#30