Sort by metadata by hacknus · Pull Request #210 · jannistpl/egui-file-dialog

hacknus · 2024-11-30T12:55:36Z

Feature request to display metadata and sort by size, date etc (#165)

This PR relies on #184.

implementation of TableBuilder
waiting for fix of egui tables (selection bug): Click and hover not work when interactive with none-interactive widgets(such as Label) in Table emilk/egui#5045, done with workaround
sorting implemented
truncating of date needs to be implemented. show time only for today, yesterday
multiple selection adapted for this change
col width needs to be set (especially for the last column, seems to be a bug with egui layouting...)

EDIT: moved this PR over here so you can review/edit, the diffs here should be more clear once #184 is merged.

jannistpl · 2024-11-30T22:04:08Z

Thank you for the implementation! I'll do a review once #184 is merged and the changes here are cleaned up.
However, I think we'll have quite a few merge conflicts here when #184 is squash merged.

hacknus · 2024-11-30T23:26:35Z

Sure! I'll solve the conflicts before your review.

hacknus · 2024-12-06T07:35:29Z

no more merge conflicts, up to date with develop. But the issue with the column width is not solved.

# Conflicts: # Cargo.toml

jannistpl

I've now found the time to do a first code review :)
But I haven't been able to test it yet...
Thanks for the work!

src/file_dialog.rs

src/information_panel.rs

jannistpl · 2025-01-02T15:54:48Z

@hacknus what is the status of the width?

Ideally there should also be the option to display the details or, like before, to only display the file name.

hacknus · 2025-01-02T19:14:01Z

@hacknus what is the status of the width?

I tried some more things but have not found a way for a clean fix..

Ideally there should also be the option to display the details or, like before, to only display the file name.

Yes, I can implement this.

hacknus · 2025-01-03T09:38:34Z

Done!
But I still was not able to fix the width-issue. I need some help there, as I do not understand the widgets/space acquisition well enough.

hacknus · 2025-01-03T09:55:58Z

Somehow the scrolling does not work anymore when I drop a file. Since it only renders the files in view,

let primary_selected = self.is_primary_selected(item);

this is never true, so it will never run the scroll_to_me() function:

if primary_selected && self.scroll_to_selection {
    row.response().scroll_to_me(Some(egui::Align::Center));
    self.scroll_to_selection = false;
}

Gotta look into this.

jannistpl · 2025-01-03T11:02:49Z

Is the sort_order and sort_by in the config just the initial sorting config? Can this still be changed by the user?

hacknus · 2025-01-03T11:33:15Z

Is the sord_order and sord_by in the config just the initial sorting config? Can this still be changed by the user?

yes, by clicking on the individual headers in the window.

hacknus · 2025-01-03T23:42:51Z

Okay, so the scroll bug is fixed. From my side I think all that is left is the error with the width of the central panel. ~~I think this is a general issue that concerns the right-side panel.~~ I don't have enough experience here and would require help to fix this.
If you have additional inputs / code reviews I'll implement your suggestions.

As for now, this feature is definitely usable, but because of the bug with the width not ready.

jannistpl · 2025-01-04T20:26:05Z

Okay, so the scroll bug is fixed. From my side I think all that is left is the error with the width of the central panel. I think this is a general issue that concerns the right-side panel. I don't have enough experience here and would require help to fix this. If you have additional inputs / code reviews I'll implement your suggestions.

As for now, this feature is definitely usable, but because of the bug with the width not ready.

Awesome, thanks for the update. I'll check over the next few weeks to see if I can get the width fixed. But I've never done anything with the egui-extras tables myself. So I have to try it out first :)

# Conflicts: # src/file_dialog.rs

hacknus · 2025-01-04T21:24:36Z

Awesome, thanks for the update. I'll check over the next few weeks to see if I can get the width fixed. But I've never done anything with the egui-extras tables myself. So I have to try it out first :)

The issue is not just with the tables, I think it is related to the issue we have with the right-side-panel where the width cannot really be set appropriately and it just extends the window to the max...
Looking forward to your inputs/findings!

bircni · 2025-01-05T21:21:58Z

@hacknus maybe use grid instead of table?
this fixed my issues with the width i had

hacknus · 2025-01-05T21:40:50Z

@hacknus maybe use grid instead of table? this fixed my issues with the width i had

Might be worth looking into. But I'm not sure if the selecting/highlighting can be done as nicely in the grid.

EDIT: Also not sure if it would be as easy to only render the currently visible lines with a grid.

hacknus · 2025-01-05T21:53:01Z

~~@FluxxCode is there a way how we can access the width of the width of the left panel?~~
nevermind, that would not help..

hacknus · 2025-01-05T22:05:51Z

The table-bug has already been reported (one year ago...): emilk/egui#3680

It's not the same as for the width in the right-side-panel.

jannistpl · 2025-01-08T16:51:40Z

The table-bug has already been reported (one year ago...): emilk/egui#3680

If this is a bug in egui, I'm not sure it's worth putting a lot of energy into debugging it. At least here in this project. We should rather open a PR at egui.

The rendering problem with the grid is a good point. Unfortunately, this makes it impossible for us to use the grid as a workaround.

hacknus · 2025-01-08T16:57:17Z

The table-bug has already been reported (one year ago...): emilk/egui#3680

If this is a bug in egui, I'm not sure it's worth putting a lot of energy into debugging it. At least here in this project. We should rather open a PR at egui.

Yes, I agree. I tried looking into the egui-code but I haven't been able to figure out where the bug originates.

# Conflicts: # src/config/mod.rs # src/data/directory_content.rs # src/file_dialog.rs # src/information_panel.rs

jannistpl · 2025-02-04T21:15:51Z

@hacknus FYI renamed branch develop to main

jannistpl · 2025-02-04T21:18:23Z

I didn't know I could just rename the branch using the Github interface, lol

# Conflicts: # Cargo.toml # src/file_dialog.rs

# Conflicts: # src/config/labels.rs # src/config/mod.rs # src/file_dialog.rs

# Conflicts: # Cargo.toml # src/file_dialog.rs

# Conflicts: # Cargo.toml # src/data/directory_content.rs # src/file_dialog.rs

hacknus added 6 commits December 6, 2024 11:25

fix typo

c9dca59

truncate date

9c1ed8e

fixed selection

9291016

sorting implemented

860e256

restructure code

593a5ef

clippy

0e3bd3b

hacknus force-pushed the sort_by_metadata branch from ab5f4ff to 0e3bd3b Compare December 6, 2024 10:28

Merge branch 'develop' into sort_by_metadata

6685bf2

# Conflicts: # Cargo.toml

jannistpl reviewed Dec 28, 2024

View reviewed changes

src/file_dialog.rs Outdated Show resolved Hide resolved

src/file_dialog.rs Outdated Show resolved Hide resolved

src/information_panel.rs Outdated Show resolved Hide resolved

hacknus added 3 commits December 30, 2024 12:27

move helper functions to utils.rs

1a2e081

rustfmt

4cfd2e8

labels moved to labels.rs

06019d5

moved sorting configuration to FileDialogConfig

a957a36

fix scroll bug with tables

2eb1a75

hacknus added 2 commits January 4, 2025 01:29

fix scroll bug with tables, final!

284fe40

header typo fix

1d6effe

hacknus added 2 commits January 4, 2025 22:20

Merge branch 'develop' into sort_by_metadata

7c884fc

# Conflicts: # src/file_dialog.rs

rustfmt

288accb

jannistpl mentioned this pull request Jan 8, 2025

Option to display file sizes and modification dates, and optionally sort by them #165

Open

hacknus added 2 commits January 28, 2025 12:15

Merge branch 'develop' into sort_by_metadata

1ffb5e1

# Conflicts: # src/config/mod.rs # src/data/directory_content.rs # src/file_dialog.rs # src/information_panel.rs

rustfmt and pick directory fix

ac9bdce

jannistpl changed the base branch from develop to main February 4, 2025 21:15

jannistpl changed the base branch from main to develop February 4, 2025 21:16

hacknus added 8 commits February 9, 2025 10:38

Merge branch 'main' into sort_by_metadata

25c9b40

# Conflicts: # Cargo.toml # src/file_dialog.rs

update from main

e463dae

Merge remote-tracking branch 'origin/main' into sort_by_metadata

703760f

# Conflicts: # src/config/labels.rs # src/config/mod.rs # src/file_dialog.rs

merge main into this branch

f6e26ea

Merge remote-tracking branch 'origin/main' into sort_by_metadata

3ccf371

# Conflicts: # Cargo.toml # src/file_dialog.rs

replace deprecated function

2719e32

Merge remote-tracking branch 'origin/main' into sort_by_metadata

fa44fd6

# Conflicts: # Cargo.toml # src/data/directory_content.rs # src/file_dialog.rs

update to egui 0.33

4423762

Conversation

hacknus commented Nov 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jannistpl commented Nov 30, 2024

Uh oh!

hacknus commented Nov 30, 2024

Uh oh!

hacknus commented Dec 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jannistpl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jannistpl commented Jan 2, 2025

Uh oh!

hacknus commented Jan 2, 2025

Uh oh!

hacknus commented Jan 3, 2025

Uh oh!

hacknus commented Jan 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jannistpl commented Jan 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hacknus commented Jan 3, 2025

Uh oh!

hacknus commented Jan 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jannistpl commented Jan 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hacknus commented Jan 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bircni commented Jan 5, 2025

Uh oh!

hacknus commented Jan 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hacknus commented Jan 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hacknus commented Jan 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jannistpl commented Jan 8, 2025

Uh oh!

hacknus commented Jan 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jannistpl commented Feb 4, 2025

Uh oh!

jannistpl commented Feb 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hacknus commented Nov 30, 2024 •

edited

Loading

hacknus commented Dec 6, 2024 •

edited

Loading

hacknus commented Jan 3, 2025 •

edited

Loading

jannistpl commented Jan 3, 2025 •

edited

Loading

hacknus commented Jan 3, 2025 •

edited

Loading

jannistpl commented Jan 4, 2025 •

edited

Loading

hacknus commented Jan 4, 2025 •

edited

Loading

hacknus commented Jan 5, 2025 •

edited

Loading

hacknus commented Jan 5, 2025 •

edited

Loading

hacknus commented Jan 5, 2025 •

edited

Loading

hacknus commented Jan 8, 2025 •

edited

Loading