Skip to content

Parse execCommand to do command including space #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2025
Merged

Parse execCommand to do command including space #193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions cmd/access-helper/exec.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@ package main

import (
"context"
"fmt"
"os"
"os/exec"

"github.com/google/shlex"
"github.com/janog-netcon/netcon-problem-management-subsystem/pkg/containerlab"
)

Expand All @@ -27,7 +29,14 @@ func (h *ExecAccessHelper) access(
execCommand = v
}

cmd := exec.CommandContext(ctx, "docker", "exec", "-it", containerDetails.Name, execCommand)
commands, err := shlex.Split(execCommand)
if err != nil {
return fmt.Errorf("failed to parse exec command: %w", err)
}

commands = append([]string{"exec", "-it", containerDetails.Name}, commands...)

cmd := exec.CommandContext(ctx, "docker", commands...)

cmd.Stdout = os.Stdout
cmd.Stderr = os.Stderr
Expand All @@ -37,7 +46,7 @@ func (h *ExecAccessHelper) access(
return err
}

err := cmd.Wait()
err = cmd.Wait()
if _, ok := err.(*exec.ExitError); ok {
// User may occur ExitError, but it's not needed to handle here.
return nil
Expand Down
Loading