forked from ictsc/ictsc-score-server
-
Notifications
You must be signed in to change notification settings - Fork 0
Update dependency rubocop-rails to v2.33.4 #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
renovate
wants to merge
1
commit into
master
Choose a base branch
from
renovate/rubocop-rails-2.x-lockfile
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
859217a to
d703875
Compare
d703875 to
048fec2
Compare
048fec2 to
7dff9a3
Compare
7dff9a3 to
bf0677e
Compare
bf0677e to
99e6ea0
Compare
99e6ea0 to
3065fef
Compare
3065fef to
8c82526
Compare
8c82526 to
eb45883
Compare
eb45883 to
a5be1a8
Compare
a5be1a8 to
c79f3cc
Compare
c79f3cc to
b9a4bba
Compare
b9a4bba to
05aa01a
Compare
05aa01a to
8af7b3a
Compare
8af7b3a to
6764ec3
Compare
6764ec3 to
008a098
Compare
bd48810 to
76475aa
Compare
76475aa to
18d587d
Compare
18d587d to
ada921a
Compare
ada921a to
843cb39
Compare
843cb39 to
a7d11db
Compare
a7d11db to
4a4e05d
Compare
4a4e05d to
d5b14e7
Compare
d5b14e7 to
0290448
Compare
0290448 to
544fb2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
0 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
2.21.1->2.33.4Release Notes
rubocop/rubocop-rails (rubocop-rails)
v2.33.4Compare Source
Bug fixes
Rails/FindByOrAssignmentMemoizationwhen using endless method definition. ([@koic][])Rails/FindBywhenwheretakes a block. ([@earlopain][])Rails/ActionControllerFlashBeforeRenderwhen flash is called in a block. ([@5hun-s][])v2.33.3Compare Source
Bug fixes
Rails/FindByOrAssignmentMemoization. ([@earlopain][])v2.33.2Compare Source
Bug fixes
Rails/ReadWriteAttributewith a frozen string attribute name. ([@viralpraxis][])v2.33.1Compare Source
Bug fixes
Rails/TransactionExitStatementwhentransactionis part of a method chain. ([@earlopain][])Rails/OrderArgumentscop false positives when using column index argument. ([@viralpraxis][])Rails/WhereExistswhenexists?is given multiple or splat arguments. ([@lovro-bikic][])v2.33.0Compare Source
New features
Rails/FindByOrAssignmentMemoizationcop. ([@r7kamura][])Rails/OrderArguments. ([@lovro-bikic][])Bug fixes
Rails/PluckIdandRails/PluckInWhere. ([@r7kamura][])Rails/EnvLocalwhen having preceding conditions. ([@fatkodima][])Rails/Pluckwhenmapmethod call is used in a block without a receiver. ([@koic][])Rails/Outputwhenpmethod is a DSL. ([@koic][])Rails/TransactionExitStatementwhenbreakis used in loop in transactions. ([@koic][])Rails/IndexWithhas nested offenses. ([@lovro-bikic][])Changes
Lint/UselessMethodDefinition. ([@r7kamura][])Rails/EnumSyntaxinclude the lib directory by default. ([@koic][])Rails/IndexWithas unsafe autocorrect. ([@tejasbubane][])v2.32.0Compare Source
Bug fixes
Rails/TimeZonecop error on invalid string literal encoding. ([@viralpraxis][])Rails/SchemaCommentwhen the comment is passed as a local variable. ([@earlopain][])Changes
v2.31.0Compare Source
New features
itblock parameter inRailscops. ([@koic][])Bug fixes
RuboCop::Cop::EnforceSuperclassbeing redefined. ([@davidrunger][])v2.30.3Compare Source
Bug fixes
Rails/RelativeDateConstantwhen assigning a lambda/proc with numblock. ([@earlopain][])Rails/ReversibleMigrationindrop_tablewith numblock. ([@earlopain][])Rails/CreateTableWithTimestampswith numblocks. ([@earlopain][])Rails/UniqBeforePluckwhen using a numblock withuniq. ([@earlopain][])Rails/SaveBangaware of numblocks. ([@earlopain][])Rails/TransactionExitStatementaware of numblocks. ([@earlopain][])Changes
Rails/ReflectionClassName: Accept method calls on local variables. ([@exterm][])Lint/UselessAccessModifieraware ofActiveSupport::ConcernandModule#concerning/Module#concerncore extensions. ([@earlopain][])Rails/Delegatefor controllers. ([@earlopain][])v2.30.2Compare Source
Bug fixes
Rails/LexicallyScopedActionFilterwhen action methods are delegated. ([@vlad-pisanov][])Rails/Delegatewhenmodule_functionis used. ([@ydakuka][])Rails/UniqBeforePluckwhenpluckanduniqueare on different lines. ([@earlopain][])v2.30.1Compare Source
Bug fixes
AllCops: TargetRailsVersion. ([@koic][])AllCops: MigratedSchemaVersion. ([@koic][])v2.30.0Compare Source
New features
Bug fixes
Rails/FilePathcop to correctly handleFile.joinwith variables and ignore leading and multiple slashes in string literal arguments forRails.root.joinandFile.join. ([@ydakuka][])Rails/Delegateby adding delegation detection forself.class, constants, class variables, global variables, and instance variables. ([@ydakuka][])v2.29.1Compare Source
Bug fixes
Rails/StrongParametersExpectwhen usingpermitwith no arguments. ([@koic][])Rails/StrongParametersExpectwhen using a leading dot multiline call torequirewithpermit. ([@koic][])Rails/DuplicateAssociationto handle alias. ([@ydakuka][])TypeErrorcaused by passing array literals as arguments toFilemethods inRails/FilePathcop. ([@ydakuka][])TypeErrorcaused by passing array literals as arguments toFilemethods inRails/RootPathnameMethodscop. ([@ydakuka][])Rails/SaveBangto properly handle instance variables. ([@ydakuka][])v2.29.0Compare Source
New features
Rails/MultipleRoutePathscop. ([@koic][])Rails/StrongParametersExpectcop. ([@koic][])Bug fixes
Rails/ReversibleMigrationwhen callingdrop_tablewithout any arguments. ([@earlopain][])Rails/TimeZonewhen Time.new has a string argument. ([@mterada1228][])Rails/IndexByandRails/IndexWithwhenmap { ... }.to_his enclosed in another block. ([@franzliedke][], [@eugeneius][])Rails/IndexByandRails/IndexWithto support numbered block parameters. ([@eugeneius][])Rails/IndexWithwhen the value is a hash literal without braces. ([@koic][], [@eugeneius][])Rails/HttpPositionalArgumentscop false positives with arguments forwarding. ([@viralpraxis][])Changes
AllCops: MigratedSchemaVersion. ([@koic][])v2.28.0Compare Source
New features
AllCops: MigratedSchemaVersionconfig. ([@koic][])Bug fixes
Rails/SelectMapwhenselecthas no receiver and method chains are used. ([@masato-bkn][])Rails/RedundantActiveRecordAllMethodwhen usingallmethod in block. ([@masato-bkn][])Rails/FilePathcop error onjoinmethod with implicit receiver. ([@viralpraxis][])Rails/FilePathcop error in case of extra operations inRails.rootinterpolation. ([@viralpraxis][])Rails/FilePathcop error with rescuedRails.root. ([@viralpraxis][])Changes
Rails/Pluckto ignoremap/collectwhen used inside blocks to prevent potential N+1 queries. ([@masato-bkn][])v2.27.0Compare Source
Bug fixes
Rails/EnumSyntaxwhen positional arguments are used and options are not passed as keyword arguments. ([@koic][])Rails/TimeZoneshould not report offense onString#to_timewith timezone specifier. ([@armandmgt][])Changes
Rails/TransactionExitStatementon Rails >= 7.2. ([@earlopain][])Rails/EnvLocalto handle negated conditions. ([@fatkodima][])Rails/SelectMapto handle safe navigation operators. ([@fatkodima][])v2.26.2Compare Source
Bug fixes
Rails/EnumSyntaxwhen using Ruby 2.7. ([@koic][])Rails/ActionControllerFlashBeforeRenderin combination with implicit returns. ([@earlopain][])Rails/FilePathwhen passing an array toFile.join. ([@earlopain][])Changes
filterinRails/CompactBlank. ([@masato-bkn][])v2.26.1Compare Source
Bug fixes
Rails/EnumSyntaxfor non-literal mappings. ([@earlopain][])Rails/WhereEquals,Rails/WhereNot, andRails/WhereRangewhen qualifying the database name. ([@earlopain][])Changes
Rails/ApplicationRecordto ignore migrations. ([@fatkodima][])Rails/EnumSyntaxto autocorrect underscored options. ([@fatkodima][])v2.26.0Compare Source
New features
Rails/EnumSyntaxcop. ([@maxprokopiev][], [@koic][])Rails/EnumHashcop. ([@ytjmt][])Rails/EnumUniquenesscop. ([@ytjmt][])Bug fixes
Rails/BulkChangeTablewhen the block forchange_tableis empty. ([@earlopain][])Rails/RenderPlainTextwhen the content type is passed as a constant. ([@earlopain][])Rails/Validationwhen passing no arguments. ([@earlopain][])Rails/WhereNotwhen using placeholder without second argument. ([@earlopain][])Rails/ActionControllerFlashBeforeRenderwhen using implicit render or rescue blocks. ([@tldn0718][])Rails/CompactBlankwhen usingcollection.reject!. ([@koic][])Rails/RedundantPresenceValidationOnBelongsTowhen removingpresencewould leave other non-validation options likeallow_blankwithout validations. ([@earlopain][])Rails/PluralizationGrammaraware of byte methods. ([@earlopain][])paramsreceiver by default forStyle/CollectionMethods. ([@koic][])Rails/WhereEqualswhen the second argument is not yet typed (where("foo = ?", )). ([@earlopain][])Changes
Rails/CompactBlankto handleselect(&:present?). ([@fatkodima][])Rails/IgnoredSkipActionFilterOptionto handle multiple callbacks. ([@fatkodima][])Rails/WhereEqualsaware ofwhere.not(...). ([@earlopain][])Rails/RootPathnameMethodsto detect offenses onDir.[]. ([@r7kamura][])v2.25.1Compare Source
Bug fixes
Rails/BulkChangeTable. ([@ccutrer][])Rails/NotNullColumnwhen the block forchange_tableis empty. ([@earlopain][])Rails/WhereRangeautocorrect for complex expressions. ([@fatkodima][])Rails/WhereRangeto correctly handle template strings with extra spaces. ([@fatkodima][])Changes
Rails/Validation. ([@ChaelCodes][])Rails/LinkToBlanklook intolink_to_ifandlink_to_unless, too. ([@fwolfst][])Rails/SkipsModelValidationsas unsafe. ([@koic][])Rails/WhereRangeas unsafe autocorrect. ([@fatkodima][])v2.25.0Compare Source
New features
Rails/WhereRangecop. ([@fatkodima][])Bug fixes
Rails/Validationwhen usingvalidates_size_of. ([@koic][])Rails/SkipsModelValidationswhen usinginsertorinsert!with a safe navigator. ([@tldn0718][])Rails/UnknownEnvwhen using Rails 7.1. ([@lukasfroehlich1][])Changes
Rails/UnusedIgnoredColumnsby default. ([@earlopain][])change_tablecalls for offenses. ([@ccutrer][])Rails/HttpStatusaware of Rails-specific response assertions. ([@tldn0718][])TargetRailsVersionthe newrequires_gemAPI. ([@amomchilov][])v2.24.1Compare Source
Bug fixes
Rails/ActionControllerFlashBeforeRenderwhen returningredirect_to. ([@earlopain][])Rails/UniqBeforePluckwithEnforcedStyle: aggressivewhen no receiver. ([@earlopain][])Rails/UnusedIgnoredColumnswhen without tables in db/schema.rb. ([@koic][])Rails/WhereMissingwith leadingwherewithout receiver. ([@earlopain][])Rails/ExpandedDateRangewhen passing an argument only to the first method call for weeks. ([@earlopain][])Rails/ActiveSupportOnLoadwhen calling without arguments. ([@earlopain][])Rails/SaveBangifpersisted?is checked on parenthesised expression. ([@earlopain][])Rails/TimeZoneaware of safe navigation. ([@earlopain][])Changes
active_record_sqlite3adaptertoRails/ActiveSupportOnLoad. ([@earlopain][])v2.24.0Compare Source
New features
Bug fixes
Rails/FindBywhen using multi-line leading dot method calls. ([@ymap][])Rails/WhereExistswithEnforcedStyle: whereand implicit receivers. ([@earlopain][])Changes
Rails/EnvironmentVariableAccessaware of initializers. ([@markokajzer][])object_idfromRails/DangerousColumnNamestargets. ([@r7kamura][])v2.23.1Compare Source
Bug fixes
Rails/WhereNotwhen calling.whereon an implicit receiver (e.g. inside model code). ([@bquorning][])v2.23.0Compare Source
New features
Bug fixes
Rails/WhereMissingwhere join method is called without arguments. ([@fatkodima][])Rails/Pluckwhen using safe navigation method calls. ([@koic][])Rails/ActiveSupportAliases,Rails/FindBy,Rails/FindById,Rails/Inquiry,Rails/PickRails/PluckId,Rails/PluckInWhere,Rails/WhereEquals,Rails/WhereExists, andRails/WhereNotcops aware of safe navigation operator. ([@koic][])Changes
Rails/PluckInWhereto check for.idscall. ([@fatkodima][])Nokogiri::HTML.parseandNokogiri::HTML5.parseonRails/ResponseParsedBody. ([@r7kamura][])where.notforRails/PluckInWhere. ([@fatkodima][])v2.22.2Compare Source
Bug fixes
Rails/UnknownEnvwhen using Rails 7.1. ([@koic][])Rails/RedundantActiveRecordAllMethodcop when used with RuboCop 1.51 or lower. ([@koic][])Changes
Rails/RedundantActiveRecordAllMethodto ignoredelete_allanddestroy_allwhen receiver is an association. ([@masato-bkn][])v2.22.1Compare Source
Bug fixes
Rails/DuplicateAssociationwhen using duplicatebelongs_toassociations of same class without other arguments. ([@koic][])v2.22.0Compare Source
New features
Rails/EnvLocalcop. ([@sambostock][])Rails/DuplicateAssociationaware of duplicateclass_name. ([@koic][])Rails/RedundantActiveRecordAllMethod. ([@koic][])Bug fixes
Rails/NotNullColumnwhen usingnull: falsefor MySQL's TEXT type. ([@koic][])Rails/Outputwhen output method is called with block argument. ([@koic][])Rails/RedundantActiveRecordAllMethodwhen using RuboCop 1.51 or lower. ([@koic][])Rails/RedundantPresenceValidationOnBelongsTowhen usingvalidateswith:ifor:unlessoptions. ([@koic][])Rails/HasManyOrHasOneDependentdoes not add offence when has_many or has_one is called on an explicit receiver. ([@samrjenkins][])Rails/SaveBangto ignore parenthesis. ([@fatkodima][])Changes
Rails/DangerousColumnNames. ([@r7kamura][])Rails/ActionFiltercop; it will be disabled by default. ([@koic][])localas an environment forRails/UnknownEnvfrom Rails 7.1 onward. ([@ghiculescu][])v2.21.2Compare Source
Bug fixes
Rails/RedundantActiveRecordAllMethodwhen using someEnumerable's methods with block argument. ([@koic][])Rails/SelectMapwhen usingselect(:column_name).map(&:column_name)without receiver model. ([@koic][])Rails/RedundantActiveRecordAllMethodwhenallhas parentheses. ([@masato-bkn][])Rails/UniqueValidationWithoutIndexwith bare validate. ([@jamiemccarthy][])Rails/RedundantActiveRecordAllMethodwhen receiver is not an Active Record model. ([@koic][])Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.