Skip to content

Store hooks as property of compilation #1869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Store hooks as property of compilation #1869

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,8 @@ const { AsyncSeriesWaterfallHook } = require("tapable");
/** @typedef {Array<{ name: string, source: import('webpack').sources.Source, info?: import('webpack').AssetInfo }>} PreviousEmittedAssets */
/** @typedef {{ publicPath: string, js: Array<string>, css: Array<string>, manifest?: string, favicon?: string }} AssetsInformationByGroups */
/** @typedef {import("./typings").Hooks} HtmlWebpackPluginHooks */
/**
* @type {WeakMap<Compilation, HtmlWebpackPluginHooks>}}
*/
const compilationHooksMap = new WeakMap();

const compilationHooksSymbol = Symbol.for('html-webpack-plugin/compilation-hooks');

class HtmlWebpackPlugin {
// The following is the API definition for all available hooks
Expand Down Expand Up @@ -98,7 +96,7 @@ class HtmlWebpackPlugin {
* @returns {HtmlWebpackPluginHooks}
*/
static getCompilationHooks(compilation) {
let hooks = compilationHooksMap.get(compilation);
let hooks = compilation[compilationHooksSymbol];

if (!hooks) {
hooks = {
Expand All @@ -109,7 +107,9 @@ class HtmlWebpackPlugin {
beforeEmit: new AsyncSeriesWaterfallHook(["pluginArgs"]),
afterEmit: new AsyncSeriesWaterfallHook(["pluginArgs"]),
};
compilationHooksMap.set(compilation, hooks);
Object.defineProperty(compilation, compilationHooksSymbol, {
value: hooks,
})
}

return hooks;
Expand Down