Skip to content

Conversation

henryqdineen
Copy link
Contributor

@henryqdineen henryqdineen commented Aug 12, 2025

We ran into an issue where HtmlWebpackPlugin where Rspack would crash with an error

/node_modules/@rspack/core/dist/index.js:1370
            push: (...newItems)=>(adm.spliceWithArray(adm.length, 0, newItems), adm.length),
                                      ^

Error: Missing field name
    at Proxy.push (/node_modules/@rspack/core/dist/index.js:1370:39)

I tracked it down to some rust code in Rspack. My fix in this PR is to just wrap the pretty-error string in an Error which would also be more accurate based on both the webpack/Rspack types.

An alternative I considered was just not adding the raw error to compilation.errors. Would that be preferred?

Thanks!

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@alexander-akait alexander-akait merged commit b733b1a into jantimon:main Aug 14, 2025
51 of 77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants