fix: compilation.errors should contain Error objects #1877
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran into an issue where HtmlWebpackPlugin where Rspack would crash with an error
I tracked it down to some rust code in Rspack. My fix in this PR is to just wrap the pretty-error string in an
Error
which would also be more accurate based on both the webpack/Rspack types.An alternative I considered was just not adding the raw error to
compilation.errors
. Would that be preferred?Thanks!