This repository was archived by the owner on Jan 27, 2026. It is now read-only.
fix(cli): cater for new potential error#2666
Merged
openshift-merge-bot[bot] merged 1 commit intojanus-idp:mainfrom May 14, 2025
Merged
fix(cli): cater for new potential error#2666openshift-merge-bot[bot] merged 1 commit intojanus-idp:mainfrom
openshift-merge-bot[bot] merged 1 commit intojanus-idp:mainfrom
Conversation
This change updates the existing condition where the CLI caters for when a package main script points to a .ts file. This addresses an update to the default behavior for how modules are handled by `require`. Signed-off-by: Stan Lewis <gashcrumb@gmail.com>
gashcrumb
requested review from
a team,
davidfestal,
jesuino and
kadel
as code owners
🦋 Changeset detectedLatest commit: 91008fe The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Member
Author
|
/retest |
davidfestal
approved these changes
May 14, 2025
Member
|
/lgtm |
openshift-merge-bot
bot
merged commit 701b93c
into
janus-idp:main
12 of 15 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates the existing condition where the CLI caters for when a package main script points to a .ts file. This addresses an update to the default behavior for how modules are handled by
require.This fixes RHIDP-6698