refactor: remove X11 support and legacy window decoration code#171
Open
refactor: remove X11 support and legacy window decoration code#171
Conversation
b5a3b67 to
df54c1c
Compare
Removes all X11-specific functionality including xprop dependency, window decoration control, and X11-specific window property handling. The extension is now Wayland-only.
df54c1c to
e728465
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copied from #168 as a result of a mistake on my part.
Originally submitted by @CleoMenezesJr
📝 Description
This PR completely removes legacy support for X11, modernizing the codebase to focus exclusively on Wayland and recent GNOME versions (45+).
Key changes include:
src/xprop.tsand all X11-specific methods in src/window.ts (e.g.,xid,decorate,size_hint).show_titlesetting and associated logic, as server-side decoration control via X11 properties is no longer applicable.This significantly reduces technical debt and simplifies the codebase.
Fixes #166
🔍 Type of Change
✅ How Has This Been Tested?
maketo ensure the project compiles successfully without the removed modules.grepsearches to verify zero remaining references toxprop,X11.Test Configuration:
📋 Checklist
Before submitting your PR, please check that: