Ability to add test listener #46
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredsburrows
force-pushed
the
master
branch
from
2dee748 to
9ebaf21
Compare
jaredsburrows
requested changes
Dec 20, 2018
| mavenLocal() | ||
| google() | ||
| maven { url "https://oss.sonatype.org/content/repositories/snapshots" } // For Spoon snapshot, until 2.0.0 is released | ||
| jcenter() |
Owner
There was a problem hiding this comment.
We need maven { url "https://oss.sonatype.org/content/repositories/snapshots" } for Spoon 2.0.
| @@ -1,5 +1,5 @@ | |||
| GROUP=com.jaredsburrows | |||
| VERSION_NAME=1.4.1-SNAPSHOT | |||
| VERSION_NAME=1.4.1-SNAPSHOT-fork-1.0.0 | |||
Owner
|
Have you tried doing this via instrumentation args? |
Author
|
Sorry, I'm just forgotten that I've done this PR. So, I'm using my master-branch for own development. If you still interested in PR, I can make it in a separate branch (actually, only 44350b commit is relevant). |
Owner
|
Have you tested this locally? Maybe we can add some tests? |
Author
|
Yep, I've tested it. And I can add more checks to Task/Plugin Specs. If you are feel ok about the idea, I'll prepare separate PR and close this one. |
Owner
|
You can just clean up this PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! I'm working on internal plugin for tracking tests state. For that reason I have to add listener to the spoon runner. Looks like you originally planned this ability, so I've decided to make a PR instead of maintaining own fork.