Merged
Conversation
Owner
|
@corradodellorusso - thanks and will do a review tomorrow. |
jaredwray
previously requested changes
May 23, 2025
Owner
jaredwray
left a comment
There was a problem hiding this comment.
I noticed you replaced the wrap function with your getOrSet. Should we do that as I do plan long term to have wrap be in its own module that enables cache-manager and cacheable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This pull request introduces a new
getOrSetmethod to theCacheableclass, refactors thewrapfunction to leverage this new method, and adds corresponding tests to ensure functionality. The changes aim to improve cache management by simplifying code and preventing cache stampedes.New Features:
getOrSetmethod to theCacheableclass, which retrieves a cached value or computes and caches it if not present. This method includes support for TTL and error caching. (packages/cacheable/src/index.ts)Refactoring:
wrapfunction to delegate caching logic to the newgetOrSetmethod, simplifying the implementation. (packages/cacheable/src/wrap.ts)Type and Import Updates:
GetOrSetOptionstype to encapsulate options for thegetOrSetmethod. (packages/cacheable/src/index.ts)coalesceAsyncinindex.tsand removed it fromwrap.tsas it is now used exclusively ingetOrSet. (packages/cacheable/src/index.ts,packages/cacheable/src/wrap.ts) [1] [2]Testing Enhancements:
getOrSetmethod to verify proper caching behavior and prevention of cache stampedes. (packages/cacheable/test/index.test.ts)wrap.test.tsby removing unused imports. (packages/cacheable/test/wrap.test.ts)