Skip to content

Fix issues with WavStream looping (Flac, Wav & MP3)#379

Open
pgrAm wants to merge 1 commit intojarikomppa:masterfrom
pgrAm:wavstream-loop
Open

Fix issues with WavStream looping (Flac, Wav & MP3)#379
pgrAm wants to merge 1 commit intojarikomppa:masterfrom
pgrAm:wavstream-loop

Conversation

@pgrAm
Copy link

@pgrAm pgrAm commented Dec 9, 2024

There were a few issues with WavStreams and looping, fixed here

  • WavStreamInstance::seek would always take the branch for OGG leading other formats to stop playing after one loop
  • The sample copying loop was using the incorrect pitch, aSamplesToRead instead of aBufferSize, causing garbage noise at the end of a loop when aSamplesToRead != aBufferSize
  • logic for WavStreamInstance::hasEnded() differed from that of WavInstance::hasEnded()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant