rust-project check TARGET
#38
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By fixing & removing the workaround for missing JSON output that swallowed all the BXL errors too.
This became necessary when I was debugging a sysroot that by mistake did not have rust-src due to being a "minimal" rustup toolchain. I figure that might be a common mistake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: relies on the as-yet unmerged rust-lang/rust-analyzer#18043, which adds
{label}interpolation in rust-analyzer flycheck commands and allowsrust-project develop-jsonto supply the flycheck commands.Previously rust-project worked with the
$saved_fileinterpolation in rust-analyzer. This PR makes it work with a target label, substituted as{label}instead. So it's not really backwards compatible, but we could make it so. Submitting this now to get feedback.We also now emit flycheck runnables that configure rust-analyzer to do flychecks using
rust-project check.Also:
rust-project develop-json --use-clippy falserust-srccomponent. This was an undocumented requirement and rust-analyzer just doesn't work without it, so we should fail as early as possible.buck2 testrunnables, the new ones work with the rustc_test harness and OSS buck2.Attn @davidbarsky