Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the repo’s developer tooling and guidance to move from Pyright-specific configuration/ignores to using ty for type checking, along with aligning declared Home Assistant/Python versions used for development.
Changes:
- Remove per-file
pyright:directives/ignores across tests and integration code to decouple from Pyright. - Update
pyproject.tomlto usety checkfor lint/type-check tasks and remove[tool.pyright]configuration; bump HA/Python version constraints used by the project. - Simplify
AGENTS.mdguidance to focus onuvworkflows and live testing commands.
Reviewed changes
Copilot reviewed 19 out of 20 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_valve.py | Removes Pyright file-level directives. |
| tests/test_config_flow.py | Removes Pyright file-level directives. |
| tests/test_climate.py | Removes Pyright file-level directives. |
| tests/test_binary_sensor.py | Removes Pyright file-level directives. |
| tests/hubitatmaker/test_hub.py | Removes Pyright file-level directives. |
| scripts/publish.py | Removes a Pyright-specific inline ignore on tomlkit.dump. |
| pyproject.toml | Switches task to ty check, removes [tool.pyright], and bumps HA/Python constraints. |
| home_assistant | Removes Pyright file-level directive. |
| custom_components/hubitat/switch.py | Removes Pyright-specific inline ignores on attributes/method kwargs typing. |
| custom_components/hubitat/services.py | Removes Pyright-specific inline ignore in codes formatting. |
| custom_components/hubitat/lock.py | Removes Pyright-specific inline ignores on service kwargs typing. |
| custom_components/hubitat/light.py | Removes Pyright-specific inline ignores for fallback constants and service kwargs typing. |
| custom_components/hubitat/hubitatmaker/server.py | Removes Pyright-specific ignore for private attribute access. |
| custom_components/hubitat/hubitatmaker/hub.py | Removes Pyright-specific ignores around _api_request and JSON parsing/return typing. |
| custom_components/hubitat/device_trigger.py | Removes Pyright-specific ignore around schema extension typing. |
| custom_components/hubitat/cover.py | Removes Pyright-specific inline ignores on service kwargs typing. |
| custom_components/hubitat/climate.py | Removes Pyright-specific inline ignores on service kwargs typing. |
| custom_components/hubitat/alarm_control_panel.py | Removes Pyright-specific ignores for type assignments/overrides. |
| AGENTS.md | Updates agent/developer guidance to reflect uv + ty and simplifies content. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the AGENTS file, use ty for type checking.