fix: address CRAN submission policy issues#19
Merged
jasonad123 merged 4 commits intoprep/cranfrom Feb 11, 2026
Merged
Conversation
- Namespace httr2::resp_content_type() to fix runtime error
- Replace \dontrun{} with \donttest{} and @examplesIf FALSE
- Route cli_alert_*() through cli_inform() (message stream)
- Replace print() with cli_inform() in download_feed()
- Add interactive confirmation for .Renviron writes
- Fix vignette chunk label containing space
https://claude.ai/code/session_01Jp2rybPthFcWNaHPK7DioN
Preview Deployment🚀 Preview URL: https://91b0f188.mobdb.pages.dev Branch alias: https://claude-review-cran-submissio.mobdb.pages.dev |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
- Auth: test set_renviron_key() write/replace/preserve, mobdb_set_key() install path in non-interactive mode, message emission - Cache: test cli_inform()/cli_warn() message stream routing for read_from_cache(), mobdb_cache_info(), mobdb_cache_list(), mobdb_cache_clear(), and mobdb_cache_path() - Cache: test install=TRUE .Renviron write, overwrite=FALSE error, overwrite=TRUE replacement - Integration: test multiple-feeds table displays via message stream using local_mocked_bindings instead of API fixtures https://claude.ai/code/session_01Jp2rybPthFcWNaHPK7DioN
Preview Deployment🚀 Preview URL: https://efc332ab.mobdb.pages.dev Branch alias: https://claude-review-cran-submissio.mobdb.pages.dev |
The cache expiry message was passed as a named argument instead of a named character vector, preventing proper message stream routing. https://claude.ai/code/session_01Jp2rybPthFcWNaHPK7DioN
- Use hasName() before accessing validation_report, url_html, url_json via $ on tibbles to prevent "Unknown or uninitialised column" warnings - Guard url_html/url_json extraction with hasName() since the API may not always include these fields - Add url_html and url_json to test mock validation_report tibble - Add assertions for html_report and json_report extraction https://claude.ai/code/session_01Jp2rybPthFcWNaHPK7DioN
Preview Deployment🚀 Preview URL: https://620fabea.mobdb.pages.dev Branch alias: https://claude-review-cran-submissio.mobdb.pages.dev |
Preview Deployment🚀 Preview URL: https://def03844.mobdb.pages.dev Branch alias: https://claude-review-cran-submissio.mobdb.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://claude.ai/code/session_01Jp2rybPthFcWNaHPK7DioN