Skip to content

Miscellaneous Pydantic response updates #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JDCodes wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Miscellaneous Pydantic response updates #74

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
94f0b15
Make logo_url optional in members model
JDCodes Jan 15, 2026
5c7b4c6
Add Optional import to members.py
JDCodes Jan 15, 2026
35e1823
Change driver_results to a list of SessionResultDetailDriver
JDCodes Jan 16, 2026
5c1dacc
Allow flair_shortname to be optional
JDCodes Jan 16, 2026
d0cda04
Change logo_url type to support None value
JDCodes Jan 16, 2026
48d118b
Update responses.py
JDCodes Jan 16, 2026
79c17f7
updated newer api responses which resultet in an pydantic error
Jan 22, 2026
3a899ec
added results_with_team test.
Jan 23, 2026
83b9314
Allow activity in MemberProfileResponse to be optional and add test f…
Jan 23, 2026
b32c794
changed to old member.json
Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/iracingdataapi/models/members.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ class MemberRecentEvent(BaseModel):
event_name: str
event_type: str
finish_position: int
logo_url: str
logo_url: str | None = None
percent_rank: int
simsession_type: int
start_time: str
Expand Down
2 changes: 1 addition & 1 deletion src/iracingdataapi/models/responses.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ class MemberGetResponse(BaseModel):


class MemberProfileResponse(BaseModel):
activity: MemberActivity
activity: MemberActivity | None = None
Copy link
Owner

@jasondilworth56 jasondilworth56 Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you spotted a member profile in the wild activity of None?

If so, add a new file member_profile_no_activity.json to mock_return_data with that profile and add a test for it.

Copy link
Author

@JDCodes JDCodes Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added the test and mock_return_data

cust_id: int
disabled: bool
follow_counts: MemberFollowCounts
Expand Down
4 changes: 2 additions & 2 deletions src/iracingdataapi/models/results.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,15 +133,15 @@ class SessionResultDetailBase(BaseModel):

class SessionResultDetailDriver(SessionResultDetailBase):
cust_id: int
flair_shortname: str
flair_shortname: str | None = None
helmet: Helmet
team_id: int


class SessionResultDetail(SessionResultDetailBase):
cust_id: int | None = None
division_name: str | None = None
driver_results: SessionResultDetailDriver | None = None
driver_results: list[SessionResultDetailDriver] | None = None
Copy link
Owner

@jasondilworth56 jasondilworth56 Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could do with a matching file in the mock data and associated test too – I assume these are in team results but I'm not anywhere I can check at the moment.

Copy link
Author

@JDCodes JDCodes Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes its a team result, i will add a test too

Copy link
Author

@JDCodes JDCodes Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added the test and mock_return_data

flair_shortname: str | None = None
helmet: Helmet | None = None
team_id: int | None = None
Expand Down
Loading