Check more auto locations for Node version#315
Open
TheJaredWilcurt wants to merge 8 commits intojasongin:masterfrom
Open
Check more auto locations for Node version#315TheJaredWilcurt wants to merge 8 commits intojasongin:masterfrom
TheJaredWilcurt wants to merge 8 commits intojasongin:masterfrom
Conversation
Author
|
@jasongin Ready for review, open to feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This breaks out the logic into simple functions for looking up the Node version in various locations/files, and adds in some new spots.
Checks for the Node version in these places, in this order:
package.json{ devEngines: { runtime: ">= 24.0.0" } } }'>= 24.0.0'package.json{ devEngines: { runtime: { name: "node", version: ">= 24.0.0" } } }'>= 24.0.0'package.json{ volta: { node: "24.0.0" } }'24.0.0'.node-version24.0.0'24.0.0'.nvmrc24.0.0'24.0.0'.prototoolsnode = "24.0.0"'24.0.0'mise.toml[tools]\nnode = "24.0.0"'24.0.0'The
devEnginesare the only one of these I think absolutely has to be there, since it is now officially part of thepackage.jsonspec, the rest are optional 3rd party locations and could be removed.One downside is the current
NodeVersion.parsefunction does not handle ranges, such asNodeVersion.parse('>= 24.0.0'). It requires an exact version, likeNodeVersion.parse('24.0.0'). But thedevEnginesofficially support ranges.require('semver')for this.