Remove usage of update-notifier from cli.js#71
Open
igorsantos07 wants to merge 2 commits intojasonkneen:masterfrom
Open
Remove usage of update-notifier from cli.js#71igorsantos07 wants to merge 2 commits intojasonkneen:masterfrom
igorsantos07 wants to merge 2 commits intojasonkneen:masterfrom
Conversation
Damn plugin always causes issues from time to time
WalkthroughThe update-notifier dependency and all related notification checks have been removed from the CLI codebase. All require statements, notifier instance creation, and update notification calls are eliminated while preserving core CLI functionality and command handling logic. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Damn plugin always causes issues from time to time anyway, and it isn't like this package is getting new important releases anyway 😂
I tried installing the lib in multiple node versions (14, 16, 20) and they all caused different issues with that lib, the latest simply being the lib wasn't being found, even if it got correctly installed 🤷♂️
Summary by CodeRabbit