Skip to content

Conversation

@a-x-
Copy link

@a-x- a-x- commented Aug 15, 2019

fixes #207

Copy link

@sajera sajera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright

@slonofanya
Copy link

When it will be Merged? I really need it

@xxx
Copy link

xxx commented Dec 11, 2019

after applying this patch, popovers no longer open for me. There are no errors or warnings in the console. The HEAD of master (905e754) works fine.

edit:

The ref's containerEl is always null with this change applied.

may be related to https://stackoverflow.com/a/50019873/340799

edit 2:

splitting the open/enter and close/exit calls resolved this for me. It can't be assumed that the state will toggle everytime:

  componentDidUpdate(propsPrev, statePrev) {
    //log(`Component did update!`)
    const willOpen = !propsPrev.isOpen && this.props.isOpen
    const willClose = propsPrev.isOpen && !this.props.isOpen

    if (willOpen) {
      this.open()
    } else if (willClose) {
      this.close()
    }

    const didOpen = !statePrev.toggle && this.state.toggle
    const didClose = statePrev.toggle && !this.state.toggle

    if (didOpen) {
      this.enter()
    }
    else if (didClose) {
      this.exit()
    }
  }

@Serginyo90
Copy link

Please merge

Copy link

@abrad45 abrad45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stclairdaniel
Copy link

@xxx Is this going to get a release?

@pinkynrg
Copy link

@xxx will this be merged soon?

@jmansor
Copy link

jmansor commented Oct 23, 2020

@xxx will this be merged soon?

+1

@edraghiciu-vks
Copy link

Any news about this? Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warning: componentWillReceiveProps has been renamed