You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mobile was bit more work than frontend/backend because Mobile Vitals has a different header (different text + Info Tooltip) and an additional headerAction that depends on a hook, so this logic had to be moved to a conditional MobileVitalsHeader that’s now rendered in mobile/layout.
Eliminate UI Flash by Always Rendering Tabs in Mobile Insights
This PR restructures how headers and tabs are rendered in the insights/mobile area to eliminate a UI flash that occurred during initial navigation. The change introduces a persistent MobileLayout component that renders headers (including the specialized MobileVitalsHeader for the Mobile Vitals module) at a consistent layout level, moving related logic out of individual pages. The routing structure is updated to accommodate this, and redundant header rendering in downstream pages is removed. Affected tests and related modules are likewise updated to reflect the new layout and routing paradigm.
Key Changes
• Introduced new MobileLayout component in static/app/views/insights/pages/mobile/layout.tsx to handle tab and header rendering for mobile insights pages.
• Added specialized MobileVitalsHeader for rendering unique header requirements in the Mobile Vitals module.
• Removed in-page header logic from screensLandingPage.tsx, moving header and action rendering to the layout level.
• Updated routing in static/app/routes.tsx to wrap mobile pages under MobileLayout, supplying handle props to route-level children for module identification.
• Adjusted test setup in screensLandingPage.spec.tsx and updated test render logic to use the new layout and route structures.
• Removed legacy or redundant header code from screensLandingPage.tsx, overview.tsx, httpLandingPage.tsx, am1OverviewPage.tsx, and mobileOverviewPage.tsx to ensure headers and tabs are only rendered at the layout level.
• Added or modified imports and interfaces as needed for new flow.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mobile was bit more work than frontend/backend because
Mobile Vitalshas a different header (different text + Info Tooltip) and an additionalheaderActionthat depends on a hook, so this logic had to be moved to a conditionalMobileVitalsHeaderthat’s now rendered in mobile/layout.Copied from getsentry#101060
Original PR: getsentry#101060