ref: stabilize flaky replay test #44
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests have been flaky in CI for quite some time, and I got some failures again today:
I think the issue is that awaiting the network request does not guarantee that the component has re-rendered, so
.getOne
and.getMany
might still have an old reference and read stale values in CI where the machines have less power and are under more load. Locally, it always passes either way.The “fix” here is to take the first expectation after awaiting the network request and also wrap it in an
await waitFor(...)
so that it automatically retries if the first attempt fails.Note that all further calls can be kept synchronously because if the first one succeeds, the others should too.
Copied from getsentry#101062
Original PR: getsentry#101062