Skip to content

fix(ui): always render tabs in insights/ai to avoid flash during first navigation #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(ui): always render tabs in insights/ai to avoid flash during first navigation #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions static/app/routes.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1999,6 +1999,7 @@ function buildRoutes(): RouteObject[] {
children: [
{
index: true,
handle: {module: ModuleName.AGENTS},
component: make(() => import('sentry/views/insights/agents/views/overview')),
},
],
Expand All @@ -2008,6 +2009,7 @@ function buildRoutes(): RouteObject[] {
children: [
{
index: true,
handle: {module: ModuleName.MCP},
component: make(() => import('sentry/views/insights/mcp/views/overview')),
},
],
Expand Down Expand Up @@ -2080,6 +2082,7 @@ function buildRoutes(): RouteObject[] {
},
{
path: `${AGENTS_LANDING_SUB_PATH}/`,
component: make(() => import('sentry/views/insights/pages/agents/layout')),
children: [
{
index: true,
Expand Down
6 changes: 0 additions & 6 deletions static/app/views/insights/agents/views/overview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,6 @@ import OverviewAgentsDurationChartWidget from 'sentry/views/insights/common/comp
import OverviewAgentsRunsChartWidget from 'sentry/views/insights/common/components/widgets/overviewAgentsRunsChartWidget';
import {useSpans} from 'sentry/views/insights/common/queries/useDiscover';
import {useDefaultToAllProjects} from 'sentry/views/insights/common/utils/useDefaultToAllProjects';
import {AgentsPageHeader} from 'sentry/views/insights/pages/agents/agentsPageHeader';
import {getAIModuleTitle} from 'sentry/views/insights/pages/agents/settings';
import {ModuleName} from 'sentry/views/insights/types';

const TableControl = SegmentedControl<TableType>;
Expand Down Expand Up @@ -157,10 +155,6 @@ function AgentsOverviewPage() {

return (
<SearchQueryBuilderProvider {...eapSpanSearchQueryProviderProps}>
<AgentsPageHeader
module={ModuleName.AGENTS}
headerTitle={<Fragment>{getAIModuleTitle(organization)}</Fragment>}
/>
<ModuleFeature moduleName={ModuleName.AGENTS}>
<Layout.Body>
<Layout.Main fullWidth>
Expand Down
6 changes: 0 additions & 6 deletions static/app/views/insights/mcp/views/overview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,6 @@ import McpTrafficByClientWidget from 'sentry/views/insights/mcp/components/mcpTr
import McpTransportWidget from 'sentry/views/insights/mcp/components/mcpTransportWidget';
import {WidgetGrid} from 'sentry/views/insights/mcp/components/styles';
import {Onboarding} from 'sentry/views/insights/mcp/views/onboarding';
import {AgentsPageHeader} from 'sentry/views/insights/pages/agents/agentsPageHeader';
import {getAIModuleTitle} from 'sentry/views/insights/pages/agents/settings';
import {ModuleName} from 'sentry/views/insights/types';

const TableControl = SegmentedControl<ViewType>;
Expand Down Expand Up @@ -197,10 +195,6 @@ function McpOverviewPage() {

return (
<SearchQueryBuilderProvider {...eapSpanSearchQueryProviderProps}>
<AgentsPageHeader
module={ModuleName.MCP}
headerTitle={<Fragment>{getAIModuleTitle(organization)}</Fragment>}
/>
<ModuleFeature moduleName={ModuleName.MCP}>
<Layout.Body>
<Layout.Main fullWidth>
Expand Down
18 changes: 18 additions & 0 deletions static/app/views/insights/pages/agents/layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import {Fragment} from 'react';
import {Outlet, useMatches} from 'react-router-dom';

import {AgentsPageHeader} from 'sentry/views/insights/pages/agents/agentsPageHeader';
import {ModuleName} from 'sentry/views/insights/types';

function AgentsLayout() {
const handle = useMatches().at(-1)?.handle as {module?: ModuleName} | undefined;

return (
<Fragment>
{handle && 'module' in handle ? <AgentsPageHeader module={handle.module} /> : null}
<Outlet />
</Fragment>
);
}

export default AgentsLayout;