Skip to content

Conversation

@sverhoeven
Copy link
Contributor

@sverhoeven sverhoeven commented Nov 6, 2025

Some feedback was given in jasp-stats/jasp-desktop#6059 which needs to be resolved here.

TODO

  • make scrollbar even more like QMLComponents/components/JASP/Controls/JASPScrollBar.qml
    • thin
    • padded border
  • reuse translations from desktop app in web app

NICE to haves

  • only show module library url in preferences if developer mode is turned on
  • make uninstall button less alarming/bright

@sverhoeven sverhoeven changed the title Review suggestions Apply review suggestions Nov 6, 2025
@sverhoeven sverhoeven marked this pull request as ready for review November 14, 2025 13:01
@sverhoeven sverhoeven requested a review from Copilot November 14, 2025 13:01
Copilot finished reviewing on behalf of sverhoeven November 14, 2025 13:02
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses review feedback from PR #6059, focusing on improving the scrollbar styling to match the desktop app's JASPScrollBar component, adding error logging for Qt WebChannel operations, and implementing asset fallback logic.

Key changes:

  • Added error logging to Qt WebChannel initialization and info fetching
  • Implemented custom scrollbar component with padded borders matching desktop styling
  • Added fallback logic to find compatible assets when pre-release assets are unavailable

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/useJaspQtObject.ts Added console.error logging for Qt WebChannel errors
src/styles.css Added jasp-gray-darker color variable and removed scrollbar styles from body
src/App.tsx Added JaspScrollbar component and asset fallback logic in getReleaseInfo
public/index.json Updated module download counts and release URLs (data update)
package.json Version bump from 0.4.1 to 0.4.2

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +746 to +757
<div className="border-jasp-gray-darker border-r-1">
<div className="scrollbar-thin scrollbar-thumb-ring scrollbar-hover:scrollbar-thumb-thumb-hover scrollbar-track-popover h-screen overflow-y-auto border-popover border-r-1">
<div className="min-h-screen border-popover border-r-1">
<div className="min-h-screen border-jasp-gray-darker border-r-1">
{children}
</div>
</div>
</div>
</div>
);
}

Copy link

Copilot AI Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The JaspScrollbar component has 4 nested divs which creates unnecessary DOM nesting and makes it difficult to maintain. Consider consolidating the borders into fewer wrapper divs or using a single div with compound border styles if the visual effect allows it.

Suggested change
<div className="border-jasp-gray-darker border-r-1">
<div className="scrollbar-thin scrollbar-thumb-ring scrollbar-hover:scrollbar-thumb-thumb-hover scrollbar-track-popover h-screen overflow-y-auto border-popover border-r-1">
<div className="min-h-screen border-popover border-r-1">
<div className="min-h-screen border-jasp-gray-darker border-r-1">
{children}
</div>
</div>
</div>
</div>
);
}
<div
className={cn(
// Combine all border and scrollbar classes from the nested divs
"border-jasp-gray-darker border-popover border-r-1 scrollbar-thin scrollbar-thumb-ring scrollbar-hover:scrollbar-thumb-thumb-hover scrollbar-track-popover h-screen min-h-screen overflow-y-auto"
)}
>
{children}
</div>
);
}

Copilot uses AI. Check for mistakes.
@sverhoeven sverhoeven merged commit dad1ce9 into main Nov 14, 2025
4 checks passed
@sverhoeven sverhoeven deleted the review-suggestions branch November 14, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants