Skip to content

remove unnecessary empty row from result table #6071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: development
Choose a base branch
from
Open

remove unnecessary empty row from result table #6071

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4c3bbb5
remove unnecessary empty row from result table
shun2wang Nov 22, 2025
1182fc9
keep the gap in last row bottom border for visual balance.
shun2wang Nov 23, 2025
b3ccf01
dont draw bottom border for squash-left cell
shun2wang Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 2 additions & 16 deletions Desktop/html/css/jasp.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,14 +141,12 @@ tbody th {

tbody th,
tbody td {

border-bottom : none ;
border-top : none;
white-space: nowrap;
}

thead tr th {

border-bottom: thin solid ;
}

Expand Down Expand Up @@ -181,13 +179,12 @@ div.over-title-space:empty {


tbody tr:last-child th,
tbody tr:last-child td {

tbody tr:last-child td:not(.squash-left) {
border-bottom: thin solid ;
box-shadow: inset 0 -.15em 0 #ffffff ; /* minor gap between the bottom border and the background shadow to keep visual balance. */
}

tbody tr td.new-sub-group-row {

padding-top: .4em ;
}

Expand All @@ -200,7 +197,6 @@ tbody tr:first-child td {
tbody tr:nth-last-child(2) td.last-group-row,
tbody tr:nth-last-child(2) td,
tbody tr:nth-last-child(2) th {

margin-bottom: .8em ;
}

Expand Down Expand Up @@ -245,33 +241,28 @@ svg > text


.jasp_top_level {

margin-left: 1.7em ;
margin-right: 1.7em ;
}

:not(.error-state) > .jasp-analysis {

margin: 0 .7em .7em .7em ;
padding: 0 1em 1em 1em ;
position: relative;
}

#instructions {

margin: .7em ;
padding: 1em ;
/*display: inline-block ;*/
}

div.toolbar {

display: block ;
position: relative;
}

div.image-status {

position: absolute ;
top : 0 ;
left: 0 ;
Expand All @@ -284,7 +275,6 @@ div.image-status {
}

div.status {

width: 16px ;
height: 16px ;
background-size : 100% ;
Expand Down Expand Up @@ -321,7 +311,6 @@ div.jasp-image-image.no-data {
}

.error-message-positioner {

height: 0px ;
overflow: visible ;
position: relative;
Expand All @@ -331,19 +320,16 @@ div.jasp-image-image.no-data {
}

.jasp-image-image .error-message-positioner {

position: absolute ;
top: 25% ;
}

.error-message-symbol {

float: left;
margin-right: .3em;
}

.error-message-box {

z-index: 100 ;
padding: 1em ;
border-radius: .4em ;
Expand Down
2 changes: 0 additions & 2 deletions Desktop/html/js/table.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -733,8 +733,6 @@ JASPWidgets.tablePrimitive = JASPWidgets.View.extend({
chunks.push('</tr>')
}

chunks.push('<tr><td colspan="' + columnCount + '"></td></tr>')

chunks.push('</tbody>')

if (optFootnotes) {
Expand Down