Pareto plot improvements #454
Merged
juliuspfadt merged 4 commits intojasp-stats:masterfrom Jan 29, 2026
Merged
Conversation
juliuspfadt
force-pushed
the
paretonumber
branch
from
b38c574 to
b7c99a4
Compare
vandenman
approved these changes
Jan 29, 2026
Contributor
vandenman
left a comment
vandenman
left a comment
There was a problem hiding this comment.
maybe remove these two comments?
|
|
||
| .descriptivesParetoPlots_Fill <- function(column, variable, options) { | ||
|
|
||
| # tableNote <- "" |
Contributor
There was a problem hiding this comment.
Suggested change
| # tableNote <- "" |
| # does the x-variable have duplicated categories, collapse them | ||
| if (length(unique(column[[1]])) != nrow(column)) { | ||
| column <- aggregate(as.numeric(as.character(column[[2]])), by = list(column[[1]]), FUN = sum) | ||
| # tableNote <- gettext("Note: Categories with multiple counts have been collapsed.") |
Contributor
There was a problem hiding this comment.
Suggested change
| # tableNote <- gettext("Note: Categories with multiple counts have been collapsed.") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.