Skip to content

Conversation

koenderks
Copy link
Collaborator

@koenderks koenderks commented Mar 26, 2025

Add the option to add the predicted class probabilities to the data set in the prediction analysis

Steps to test:

  1. Train a machine learning classification model
  2. Save it to a .jaspML file using the interface
  3. Load it into the prediction analysis
  4. Add the predictions (including class probabilities) to the dataset

@koenderks koenderks requested review from FBartos and removed request for vandenman April 11, 2025 10:18
@FBartos
Copy link

FBartos commented Apr 13, 2025

The Save training model checkbox below the path specification is a bit unintuitive to use. I.e., I would assume that the model get's save automatically once I specify the path. Wouldn't it be better to just check whether the path == "" and save if it doesn't?
Or is it to prevent re-saving the model with every analysis update? Then nesting the path within the checkbox (so it is unavailble if not selected) would be better design IMO
(the add predictions checkbox works exactly in this way)

Copy link

@FBartos FBartos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise works and looks well!

@koenderks
Copy link
Collaborator Author

Thanks, good point about the design. I'll think a bit about it and then do it in a future PR.

@koenderks koenderks merged commit 15aba07 into jasp-stats:master Apr 13, 2025
5 checks passed
@koenderks koenderks deleted the probs branch April 13, 2025 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants