-
Notifications
You must be signed in to change notification settings - Fork 19
Add standard errors to classical meta-analysis tabular output with user control #363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: FBartos <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the changes look good, just make the title of the new column "Standard Error"
(don't forget on translation)
Co-authored-by: FBartos <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot One more improvement please:
The Statistics
section contains the confidenceInterval
checkbox hides/shows the CI column. Add a new standardError
checkbox with the same functionality for the newly added SE column (remember to add the checkbox to dependencies at the appropriate tables)
Co-authored-by: FBartos <[email protected]>
Added a |
Co-authored-by: FBartos <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds configurable standard error columns to tabular outputs in classical meta-analysis. The feature allows users to show/hide standard error information via a new checkbox in the Statistics section, with intelligent enabling/disabling based on effect size transformation settings.
Key changes:
- Added "Standard errors" checkbox with conditional availability based on transformation settings
- Implemented
.maAddSeColumn()
helper function following existing column addition patterns - Modified table creation to conditionally include Standard Error columns after estimate columns
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
inst/qml/qml_components/ClassicalMetaAnalysisStatistics.qml | Added "Standard errors" checkbox with conditional enabling logic and proper QML structure |
R/classicalmetaanalysiscommon.R | Implemented .maAddSeColumn() helper, updated table dependencies, modified table creation to include SE columns, and removed redundant column filtering |
This PR adds standard error columns to the main tabular outputs in classical meta-analysis, appearing immediately after estimate columns in:
Key Features
User Control: Added a "Standard errors" checkbox in the Statistics section that allows users to show/hide Standard Error columns, similar to the existing "Confidence intervals" checkbox functionality.
Conditional Availability: The "Standard errors" checkbox is only enabled when
transformEffectSize
is set to "none". When effect size transformations are applied (exponential, Fisher's z, etc.), the checkbox becomes disabled since standard errors don't follow simple transformations.Conditional Display: Standard Error columns only appear when both the "Standard errors" checkbox is checked AND
transformEffectSize
is set to "none". When effect size transformations are applied, Standard Error columns are hidden.Proper Positioning: Standard Error columns are positioned immediately after estimate columns in all affected tables:
Implementation Details
.maAddSeColumn()
helper function following existing patternsstandardError
option for proper caching and refreshinggettext()
User Experience
Example Usage
The implementation preserves all existing functionality while providing users with explicit control over standard error information display and preventing confusion when transformations are applied.
Fixes #362.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.