-
Notifications
You must be signed in to change notification settings - Fork 19
Auto transforms in Process Capability #402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
No, I don't know either why the unit tests are failing. They work for me locally, but fail on GitHub. Maybe @vandenman has an idea? It indeed happened recently and is likely related to ggplot2 / jaspTools / jaspGraphs? The use of the report functionality is to provide a single object with the most important results. So the transformation details can likely stay out for now. |
|
The unit tests respect the lockfiles, so please update the lockfile as well and push it in the PR. To do that:
To update all packages, use |
Co-authored-by: Julius Pfadt <[email protected]>
|
@vandenman Thank you! @Kucharssim Can you fix the unit tests based on what Don laid out? (I understand this as something that needs to be done within each PR, right? If it's a general things that needs to be done once, I can of course do it in a separate PR) |
|
Yes, sorry, I think it would be best to fix it in a separate PR. Do you have this covered? |
fixes SGC#6
I still need to write unit tests, but otherwise this is ready for review. @JTPetter do you know why the current unit tests are failing? It seems this happened recently (maybe some of the jaspTools updates or something?). Anyway, it would be great to fix that independently so that we make sure this PR doesn't break anything...
Regarding implementation, I am only wondering if
Show Reportoption should also add info about the data transform, or whether it can stay separate (as it is now). I don't know exactly what is the use of the reporting functionality, so let me know.