[jaspRegression] Add a footnote to Ordinal GLM output to clarify parameterization...#481
Open
sisyphus-jasp wants to merge 1 commit intojasp-stats:masterfrom
Open
[jaspRegression] Add a footnote to Ordinal GLM output to clarify parameterization...#481sisyphus-jasp wants to merge 1 commit intojasp-stats:masterfrom
sisyphus-jasp wants to merge 1 commit intojasp-stats:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: jasp-stats/jasp-issues#3967
Root cause
length(dv)(always 1), so numbering was wrong.What changed
R/generalizedlinearmodel.R(.glmEstimatesTableFill).seq_along(levels(...)).logit(P(Y<=k)); positive coefficients imply higher odds of lower levels, negative coefficients imply higher odds of higher levels.Caveats / reviewer checks
Implementation Plan
Root cause
R/generalizedlinearmodel.R(.glmEstimatesTableFill) lists levels + predictor labels only; parameterization meaning not explicit, so sign interpretation unclear.length(dv)used instead of number of factor levels, so labels render1:<level>repeatedly.Proposed changes
.glmEstimatesTableFill.seq_along(levels(dataset[[dv]])).logit(P(Y<=k))) and sign meaning (positive -> lower levels; negative -> higher levels).gettextf().Expected test impact
Add a footnote to Ordinal GLM output to clarify parameterization interpretation
Test Results
Automated Code Review
Approved after 1 review iteration(s).