Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion lib/rack/reverse_proxy.rb
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,17 @@ def call(env)
end
}
headers['HOST'] = uri.host if all_opts[:preserve_host]


if headers_opt = all_opts[:headers]
if headers_opt.is_a?(Proc)
headers = headers_opt.call(headers)
elsif headers_opt.is_a?(Hash)
headers.merge!(headers_opt)
else
$stderr.puts "Warning: :headers option provided with unsupported type '#{headers_opt.class}'. Expected a Hash or Proc"
end
end

session = Net::HTTP.new(uri.host, uri.port)
session.read_timeout=all_opts[:timeout] if all_opts[:timeout]

Expand All @@ -35,6 +45,7 @@ def call(env)
# DO NOT DO THIS IN PRODUCTION !!!
session.verify_mode = OpenSSL::SSL::VERIFY_NONE
end

session.start { |http|
m = rackreq.request_method
case m
Expand Down
51 changes: 51 additions & 0 deletions spec/rack/reverse_proxy_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,57 @@ def app
last_response.body.should == "secured content"
end
end

describe "with headers dictionary provided" do
context 'when the header does not exist in the source request' do
def app
Rack::ReverseProxy.new(dummy_app) do
reverse_proxy '/test', 'http://example.com/', {:headers => {'X-EXAMPLE-HEADER' => 'A value'}}
end
end

it "should add the provided headers" do
stub_request(:any, 'example.com/test/stuff')
get '/test/stuff'
a_request(:get, 'http://example.com/test/stuff').with(:headers => {"X-EXAMPLE-HEADER" => "A value"}).should have_been_made
end
end

context 'when the header already appears in the source request' do
def app
Rack::ReverseProxy.new(dummy_app) do
reverse_proxy '/test', 'http://example.com/', {:headers => {'X-EXAMPLE-HEADER' => 'New value'}}
end
end

it "should replace the existing Headers value" do
headers = {'Accept'=>'*/*', 'Cookie'=>'', 'Host'=>'example.com', 'User-Agent'=>'Ruby',
'X-Example-Header'=>'New value', 'X-Forwarded-Host'=>'example.org'}
stub_request(:any, 'example.com/test/stuff').with(:headers => headers)
get '/test/stuff', {}, {"X-EXAMPLE-HEADER" => "Original value"}
a_request(:get, 'http://example.com/test/stuff').with(:headers => {"X-EXAMPLE-HEADER" => "New value"}).should have_been_made
end
end
end

describe 'with headers proc provided' do
def app
Rack::ReverseProxy.new(dummy_app) do
reverse_proxy('/test', 'http://example.com/', :headers => lambda do |headers|
headers['X-FORWARDED-FOR'].gsub!(', 127.0.0.1', '') if headers['X-FORWARDED-FOR']
headers
end)
end
end

it "should yield the headers to the proc for manipulation" do
headers = {'Accept'=>'*/*', 'Cookie'=>'', 'Host'=>'example.com', 'User-Agent'=>'Ruby',
'X-Forwarded_For'=>'174.254.197.191', 'X-Forwarded-Host'=>'example.org'}
stub_request(:any, 'example.com/test/stuff').with(:headers => headers)
get '/test/stuff', {}, {'HTTP_X_Forwarded_For'=>'174.254.197.191, 127.0.0.1'}
a_request(:get, 'http://example.com/test/stuff').with(:headers => {"X-Forwarded-For" => "174.254.197.191"}).should have_been_made
end
end

describe "with ambiguous routes and all matching" do
def app
Expand Down