Remove constructors #10
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The point of having
StringProviderandStreamProvideris that the parser itself should not importInputStream, instead client code can wrap either strings or streams in aProviderand pass it to the parser. That way client code can be easily compiled with GWT by just removing theStreamProviderfrom the classpath.In a recent commit this separation was broken by calling
StreamProviderconstructor from the generated parser -- that should be removed. This PR also removes the call toStringProviderconstructor to maintain symmetry (client code that only needs stream-based parsing should be allowed to removeStringProviderfrom the classpath as well).