Skip to content

Conversation

@zbynek
Copy link
Contributor

@zbynek zbynek commented Oct 28, 2025

The point of having StringProvider and StreamProvider is that the parser itself should not import InputStream, instead client code can wrap either strings or streams in a Provider and pass it to the parser. That way client code can be easily compiled with GWT by just removing the StreamProvider from the classpath.

In a recent commit this separation was broken by calling StreamProvider constructor from the generated parser -- that should be removed. This PR also removes the call to StringProvider constructor to maintain symmetry (client code that only needs stream-based parsing should be allowed to remove StringProvider from the classpath as well).

@zbynek zbynek force-pushed the remove-constructors branch from 030c3a2 to ef2e86a Compare October 28, 2025 11:28
@zbynek zbynek force-pushed the remove-constructors branch from ef2e86a to fd0ae21 Compare October 28, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant