Skip to content

Conversation

@zbynek
Copy link
Contributor

@zbynek zbynek commented Oct 24, 2025

There are several problems with the CI setup this PR intends to fix:

  • the CI always runs on release branch, even for pull requests. That makes it impossible to test code before merging.
  • the no_local_java_generator_version kicks in, meaning that integration tests use the last released version of the generator instead of the local one that should be tested
  • some tests have different results on Windows depending on the line ending. This could be possibly fixed by changing the git checkout flags, but adding fixcrlf ant task makes this more robust.
  • on Windows the encoding needs to be specified so that UTF-8 encoded test grammars compile
  • the .gitignore file covers *.out and *.err files, but not files called simply out and err. Fixed by renaming.
  • some expected compiler outputs in tests were outdated

@zbynek zbynek force-pushed the ci branch 2 times, most recently from 0340f78 to 2ff627e Compare October 24, 2025 22:32
@zbynek zbynek marked this pull request as draft October 24, 2025 23:15
@zbynek zbynek force-pushed the ci branch 12 times, most recently from 0a95ab5 to 4891966 Compare October 26, 2025 10:01
@zbynek zbynek marked this pull request as ready for review October 26, 2025 15:54
@new-javacc
Copy link
Contributor

Thank you for this great clean up! I will let @MarcMazas take a quick look and merge.

@MarcMazas
Copy link
Collaborator

Looks usefull! Thanks.
I want to finish the maven plugin before, so in 1 or 2 weeks.
What about PRs #4 & #6? Still relevant?

@zbynek
Copy link
Contributor Author

zbynek commented Oct 27, 2025

@MarcMazas I'd like to see the other PRs merged as well, but I have to resolve the conflicts first.

@MarcMazas
Copy link
Collaborator

Thanks. I also would appreciate you create the same PRs for the c++ & c# versions :-).
(c# is at the same level than java, c++ has full error reporting not yet implemented, and some examples & grammars not yet fully adapted - that is why some are bypassed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants