Skip to content

Fixed SonarCloud warnings #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2024
+9 −7
Merged

Fixed SonarCloud warnings #683

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions src/main/java/com/github/underscore/Underscore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2098,13 +2098,14 @@ public static <T> java.util.concurrent.ScheduledFuture<T> delay(
final Supplier<T> function, final int delayMilliseconds) {
final java.util.concurrent.ScheduledExecutorService scheduler =
java.util.concurrent.Executors.newSingleThreadScheduledExecutor();
final java.util.concurrent.ScheduledFuture<T> future =
scheduler.schedule(
function::get,
delayMilliseconds,
java.util.concurrent.TimeUnit.MILLISECONDS);
scheduler.shutdown();
return future;
try {
return scheduler.schedule(
function::get,
delayMilliseconds,
java.util.concurrent.TimeUnit.MILLISECONDS);
} finally {
scheduler.shutdown();
}
}

public static <T> java.util.concurrent.ScheduledFuture<T> defer(final Supplier<T> function) {
Expand Down Expand Up @@ -3624,6 +3625,7 @@ public static <T> java.util.concurrent.ScheduledFuture setInterval(
final Supplier<T> function, final int delayMilliseconds) {
final java.util.concurrent.ScheduledExecutorService scheduler =
java.util.concurrent.Executors.newSingleThreadScheduledExecutor();
Runtime.getRuntime().addShutdownHook(new Thread(scheduler::shutdown));
return scheduler.scheduleAtFixedRate(
function::get,
delayMilliseconds,
Expand Down
Loading