This repository was archived by the owner on Jun 24, 2021. It is now read-only.
WIP: JDK-8208649 - FXCanvas / JFXPanel: Windows opened are not children of the SWT/Swing Window#145
Open
tomsontom wants to merge 2 commits intojavafxports:developfrom
Open
WIP: JDK-8208649 - FXCanvas / JFXPanel: Windows opened are not children of the SWT/Swing Window#145tomsontom wants to merge 2 commits intojavafxports:developfrom
tomsontom wants to merge 2 commits intojavafxports:developfrom
Conversation
Collaborator
|
Filed in JBS as JDK-8208649 |
Collaborator
|
As announced in this message, the official This sandbox repository is being retired on 1-Oct-2019. You will need to migrate your WIP pull request to the openjdk/jfx repo if you want to continue working on it. Here are instructions for migrating your pull request. The updated CONTRIBUTING.md doc has additional information on how to proceed. Once you have done this, it would be helpful to add a comment with a pointer to the new PR. The new openjdk/jfx repo will be open for pull requests on Wednesday, 2-Oct-2019. I will send email to the openjfx-dev mailing list announcing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first PoC on passing the native pointer from SWT to JavaFX to see if this can be done and would work. Currently this is just hacked into the OS-X Version but if @kevinrushforth agrees that this would be feasable the next step would be to get this working on Linux and Windows and improve the implementation.
The following things need to be considered: