Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
68 commits
Select commit Hold shift + click to select a range
26dae59
doc: capitalize "MIT License"
avivkeller Oct 30, 2024
8807549
dns: stop using deprecated `ares_query`
avivkeller Oct 30, 2024
9967080
src: use NewFromUtf8Literal in NODE_DEFINE_CONSTANT
ckerr Oct 31, 2024
a465b20
sqlite: add readOnly option
tniessen Oct 31, 2024
4379dfb
http: add diagnostic channel `http.client.request.created`
marco-ippolito Oct 31, 2024
d080f0d
module: unify TypeScript and .mjs handling in CommonJS
joyeecheung Oct 31, 2024
f67e45e
http2: fix client async storage persistence
orgads Oct 31, 2024
e2bd64d
url: refactor `pathToFileURL` to native
aduh95 Oct 31, 2024
a53c0cc
src: fix dns crash when failed to create NodeAresTask
theanarkh Nov 1, 2024
824c149
doc: improve c++ embedder API doc
gireeshpunathil Nov 1, 2024
3d979dd
deps: update amaro to 0.2.0
nodejs-github-bot Nov 1, 2024
9b6cea6
test_runner: pass `options` directly to `TestCoverage`
avivkeller Nov 1, 2024
2d6f9c6
src,lib: optimize nodeTiming.uvMetricsInfo
RafaelGSS Oct 30, 2024
d83e9fa
benchmark: add nodeTiming.uvmetricsinfo bench
RafaelGSS Oct 31, 2024
413975a
meta: show PR/issue title on review-wanted
avivkeller Nov 1, 2024
5ce3d10
build: stop pre-compiling `lint-md`
avivkeller Nov 1, 2024
d37214b
build: use rclone instead of aws CLI
targos Nov 2, 2024
4bf5731
src: refactor ECDHBitsJob signature
panva Nov 2, 2024
ba8fc73
doc: remove mention of ECDH-ES in crypto.diffieHellman
panva Nov 2, 2024
44afd67
doc: add a note on console stream behavior
gireeshpunathil Nov 2, 2024
560b2a1
http: add diagnostic channel `http.server.response.created`
marco-ippolito Nov 2, 2024
91bce94
tools: lint README lists more strictly
aduh95 Nov 2, 2024
5b9bf39
src: move more key related stuff to ncrypto
jasnell Nov 2, 2024
81859cf
os: improve path check with direct index access
mertcanaltin Nov 2, 2024
10cce65
assert: fix the string length check for printing the simple diff
Nov 2, 2024
c0db893
module: simplify `findPackageJSON` implementation
aduh95 Nov 2, 2024
51ae576
lib: make ALS default to AsyncContextFrame
Qard Nov 2, 2024
9a16fde
meta: make review-wanted message minimal
avivkeller Nov 2, 2024
68dc15e
util: fix util.getCallSites plurality
legendecas Nov 2, 2024
7b01758
Revert "fs,win: fix bug in paths with trailing slashes"
rvagg Nov 2, 2024
df4a0c9
typings: fix `ModulesBinding` types
aduh95 Nov 2, 2024
7f6ea83
doc: add write flag when open file as the demo code's intention
robberfree Nov 2, 2024
e124b0f
doc: broken `PerformanceObserver` code sample
domharrington Nov 2, 2024
57d0ea6
tools: run daily WPT.fyi report on all supported releases
panva Nov 2, 2024
7fefa36
tools: compact jq output in daily-wpt-fyi.yml action
panva Nov 2, 2024
c1b3531
deps: update sqlite to 3.47.0
nodejs-github-bot Nov 2, 2024
c2ff449
crypto: fix `RSA_PKCS1_PADDING` error message
richardlau Nov 3, 2024
8ab3140
module: simplify --inspect-brk handling
joyeecheung Nov 3, 2024
8bf99f1
meta: bump github/codeql-action from 3.26.10 to 3.27.0
dependabot[bot] Nov 3, 2024
ba907d6
meta: bump actions/checkout from 4.2.0 to 4.2.2
dependabot[bot] Nov 3, 2024
40d9ca2
meta: bump actions/cache from 4.0.2 to 4.1.2
dependabot[bot] Nov 3, 2024
f03d914
meta: bump actions/upload-artifact from 4.4.0 to 4.4.3
dependabot[bot] Nov 3, 2024
9aa694f
meta: bump rtCamp/action-slack-notify from 2.3.0 to 2.3.2
dependabot[bot] Nov 3, 2024
7f392d4
meta: bump actions/setup-node from 4.0.4 to 4.1.0
dependabot[bot] Nov 3, 2024
8dd0819
meta: bump actions/setup-python from 5.2.0 to 5.3.0
dependabot[bot] Nov 3, 2024
794cb51
tools: fix root certificate updater
richardlau Nov 1, 2024
32ff100
crypto: update root certificates to NSS 3.104
richardlau Nov 1, 2024
bdc2662
sqlite: improve error handling using MaybeLocal
tniessen Nov 4, 2024
d35cde6
util: add sourcemap support to getCallSites
marco-ippolito Nov 4, 2024
0b58160
tools: use `util.parseArgs` in `lint-md`
avivkeller Nov 4, 2024
73cfaba
deps: update acorn to 8.14.0
nodejs-github-bot Nov 5, 2024
58a7b00
test,crypto: update WebCryptoAPI WPT
panva Nov 5, 2024
03dcd70
src: nuke deprecated and un-used enum members in `OptionEnvvarSettings`
juanarbol Nov 5, 2024
270da88
lib: prefer number to string in webidl `type` function
jazelly Oct 24, 2024
e53fe03
lib: implement webidl dictionary converter and use it in structuredClone
jazelly Oct 20, 2024
25f8474
doc: update `--max-semi-space-size` description
joebowbeer Nov 5, 2024
7f68e54
path,win: fix bug in resolve and normalize
huseyinacacak-janea Nov 5, 2024
9c40cd7
tools: update ESLint to 9.14.0
dependabot[bot] Nov 5, 2024
ecc6238
test: refactor some esm tests
aduh95 Nov 5, 2024
4da8d11
assert: fix `deepStrictEqual` on errors when `cause` is not undefined
geeksilva97 Nov 5, 2024
42f4659
test: ignore unrelated events in FW watch tests
Ceres6 Nov 6, 2024
ccac4ee
src: provide workaround for container-overflow
lemire Nov 6, 2024
98e5693
doc: clarity to available addon options
preveen-stack Nov 6, 2024
c185e11
util: do not catch on circular `@@toStringTag` errors
avivkeller Nov 6, 2024
1aa7135
test: update `performance-timeline` wpt
avivkeller Sep 30, 2024
6f12f1e
doc: consistent use of word child process
gireeshpunathil Nov 6, 2024
e0145b4
tools: fix c-ares updater script for Node.js 18
richardlau Nov 6, 2024
f38cefa
lib: use `Promise.withResolvers()` in timers
anonrig Nov 6, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,16 @@ updates:
applies-to: version-updates
patterns:
- '*'

- package-ecosystem: npm
directory: /tools/lint-md
schedule:
interval: monthly
commit-message:
prefix: tools
open-pull-requests-limit: 10
groups:
lint-md:
applies-to: version-updates
patterns:
- '*'
4 changes: 2 additions & 2 deletions .github/workflows/auto-start-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,12 @@ jobs:
if: needs.get-prs-for-ci.outputs.numbers != ''
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
persist-credentials: false

- name: Install Node.js
uses: actions/setup-node@0a44ba7841725637a19e28fa30b79a866c81b0a6 # v4.0.4
uses: actions/setup-node@39370e3970a6d050c480ffad4ff0ed4d3fdee5af # v4.1.0
with:
node-version: ${{ env.NODE_VERSION }}

Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/build-tarball.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,11 @@ jobs:
if: github.event.pull_request.draft == false
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
persist-credentials: false
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@f677139bbe7f9c59b41e40162b753c062f5d49a3 # v5.2.0
uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Set up sccache
Expand All @@ -64,19 +64,19 @@ jobs:
mkdir tarballs
mv *.tar.gz tarballs
- name: Upload tarball artifact
uses: actions/upload-artifact@50769540e7f4bd5e21e526ee35c689e35e0d6874 # v4.4.0
uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # v4.4.3
with:
name: tarballs
path: tarballs
test-tarball-linux:
needs: build-tarball
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
persist-credentials: false
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@f677139bbe7f9c59b41e40162b753c062f5d49a3 # v5.2.0
uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Set up sccache
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/commit-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,13 @@ jobs:
run: |
echo "plusOne=$((${{ github.event.pull_request.commits }} + 1))" >> $GITHUB_OUTPUT
echo "minusOne=$((${{ github.event.pull_request.commits }} - 1))" >> $GITHUB_OUTPUT
- uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
fetch-depth: ${{ steps.nb-of-commits.outputs.plusOne }}
persist-credentials: false
- run: git reset HEAD^2
- name: Install Node.js
uses: actions/setup-node@0a44ba7841725637a19e28fa30b79a866c81b0a6 # v4.0.4
uses: actions/setup-node@39370e3970a6d050c480ffad4ff0ed4d3fdee5af # v4.1.0
with:
node-version: ${{ env.NODE_VERSION }}
- name: Validate commit message
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/commit-queue.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ jobs:
if: needs.get_mergeable_prs.outputs.numbers != ''
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
# Needs the whole git history for ncu to work
# See https://github.com/nodejs/node-core-utils/pull/486
Expand All @@ -71,7 +71,7 @@ jobs:

# Install dependencies
- name: Install Node.js
uses: actions/setup-node@0a44ba7841725637a19e28fa30b79a866c81b0a6 # v4.0.4
uses: actions/setup-node@39370e3970a6d050c480ffad4ff0ed4d3fdee5af # v4.1.0
with:
node-version: ${{ env.NODE_VERSION }}
- name: Install @node-core/utils
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/coverage-linux-without-intl.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,11 @@ jobs:
if: github.event.pull_request.draft == false
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
persist-credentials: false
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@f677139bbe7f9c59b41e40162b753c062f5d49a3 # v5.2.0
uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Set up sccache
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/coverage-linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,11 @@ jobs:
if: github.event.pull_request.draft == false
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
persist-credentials: false
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@f677139bbe7f9c59b41e40162b753c062f5d49a3 # v5.2.0
uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Set up sccache
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/coverage-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,11 @@ jobs:
if: github.event.pull_request.draft == false
runs-on: windows-2022
steps:
- uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
persist-credentials: false
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@f677139bbe7f9c59b41e40162b753c062f5d49a3 # v5.2.0
uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Install deps
Expand Down
32 changes: 19 additions & 13 deletions .github/workflows/daily-wpt-fyi.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,6 @@ name: Daily WPT report

on:
workflow_dispatch:
inputs:
node-versions:
description: Node.js versions (as supported by actions/setup-node) to test as JSON array
required: false
default: '["current", "lts/*", "lts/-1"]'
schedule:
# This is 20 minutes after `epochs/daily` branch is triggered to be created
# in WPT repo.
Expand All @@ -24,16 +19,27 @@ permissions:
contents: read

jobs:
report:
collect-versions:
if: github.repository == 'nodejs/node' || github.event_name == 'workflow_dispatch'
runs-on: ubuntu-latest
outputs:
matrix: ${{ steps.query.outputs.matrix }}
steps:
- id: query
run: |
matrix=$(curl -s https://raw.githubusercontent.com/nodejs/Release/refs/heads/main/schedule.json | jq -c --arg now "$(date +%Y-%m-%d)" '[with_entries(select(.value.end > $now and .value.start < $now)) | keys[] | ltrimstr("v") | tonumber] + ["latest-nightly"]')
echo "matrix=$matrix" >> "$GITHUB_OUTPUT"
report:
needs:
- collect-versions
strategy:
matrix:
node-version: ${{ fromJSON(github.event.inputs.node-versions || '["latest-nightly", "current", "lts/*", "lts/-1"]') }}
node-version: ${{ fromJSON(needs.collect-versions.outputs.matrix) }}
fail-fast: false
runs-on: ubuntu-latest
steps:
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@f677139bbe7f9c59b41e40162b753c062f5d49a3 # v5.2.0
uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Environment Information
Expand All @@ -45,7 +51,7 @@ jobs:
run: echo "NIGHTLY=$(curl -s https://nodejs.org/download/nightly/index.json | jq -r '[.[] | select(.files[] | contains("linux-x64"))][0].version')" >> $GITHUB_ENV
- name: Install Node.js
id: setup-node
uses: actions/setup-node@0a44ba7841725637a19e28fa30b79a866c81b0a6 # v4.0.4
uses: actions/setup-node@39370e3970a6d050c480ffad4ff0ed4d3fdee5af # v4.1.0
with:
node-version: ${{ env.NIGHTLY || matrix.node-version }}
check-latest: true
Expand All @@ -57,7 +63,7 @@ jobs:
SHORT_SHA=$(node -p 'process.version.split(/-nightly\d{8}/)[1]')
echo "NIGHTLY_REF=$(gh api /repos/nodejs/node/commits/$SHORT_SHA --jq '.sha')" >> $GITHUB_ENV
- name: Checkout ${{ steps.setup-node.outputs.node-version }}
uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
persist-credentials: false
ref: ${{ env.NIGHTLY_REF || steps.setup-node.outputs.node-version }}
Expand All @@ -73,7 +79,7 @@ jobs:
run: rm -rf wpt
working-directory: test/fixtures
- name: Checkout epochs/daily WPT
uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
repository: web-platform-tests/wpt
persist-credentials: false
Expand All @@ -98,7 +104,7 @@ jobs:
run: rm -rf deps/undici
- name: Checkout undici
if: ${{ env.WPT_REPORT != '' }}
uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
repository: nodejs/undici
persist-credentials: false
Expand All @@ -121,7 +127,7 @@ jobs:
run: cp wptreport.json wptreport-${{ steps.setup-node.outputs.node-version }}.json
- name: Upload GitHub Actions artifact
if: ${{ env.WPT_REPORT != '' }}
uses: actions/upload-artifact@50769540e7f4bd5e21e526ee35c689e35e0d6874 # v4.4.0
uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # v4.4.3
with:
path: out/wpt/wptreport-*.json
name: WPT Report for ${{ steps.setup-node.outputs.node-version }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/daily.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@ jobs:
build-lto:
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
persist-credentials: false
- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@0a44ba7841725637a19e28fa30b79a866c81b0a6 # v4.0.4
uses: actions/setup-node@39370e3970a6d050c480ffad4ff0ed4d3fdee5af # v4.1.0
with:
node-version: ${{ env.NODE_VERSION }}
- name: Environment Information
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/doc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,18 +24,18 @@ jobs:
if: github.event.pull_request.draft == false
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
persist-credentials: false
- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@0a44ba7841725637a19e28fa30b79a866c81b0a6 # v4.0.4
uses: actions/setup-node@39370e3970a6d050c480ffad4ff0ed4d3fdee5af # v4.1.0
with:
node-version: ${{ env.NODE_VERSION }}
- name: Environment Information
run: npx envinfo
- name: Build
run: NODE=$(command -v node) make doc-only
- uses: actions/upload-artifact@50769540e7f4bd5e21e526ee35c689e35e0d6874 # v4.4.0
- uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # v4.4.3
with:
name: docs
path: out/doc
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/find-inactive-collaborators.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,13 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
fetch-depth: 0
persist-credentials: false

- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@0a44ba7841725637a19e28fa30b79a866c81b0a6 # v4.0.4
uses: actions/setup-node@39370e3970a6d050c480ffad4ff0ed4d3fdee5af # v4.1.0
with:
node-version: ${{ env.NODE_VERSION }}

Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/find-inactive-tsc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,21 +20,21 @@ jobs:

steps:
- name: Checkout the repo
uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
fetch-depth: 0
persist-credentials: false

- name: Clone nodejs/TSC repository
uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
fetch-depth: 0
path: .tmp
persist-credentials: false
repository: nodejs/TSC

- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@0a44ba7841725637a19e28fa30b79a866c81b0a6 # v4.0.4
uses: actions/setup-node@39370e3970a6d050c480ffad4ff0ed4d3fdee5af # v4.1.0
with:
node-version: ${{ env.NODE_VERSION }}

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/license-builder.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
if: github.repository == 'nodejs/node'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
persist-credentials: false
- run: ./tools/license-builder.sh # Run the license builder tool
Expand Down
Loading
Loading