Merge pull request #281 from opensource9ja/fix/274-getdummies

get_dummies not working properly

Author: risenW

danfojs-browser/src/core/get_dummies.js

@@ -77,7 +77,7 @@ function get_dummy(kwargs = {}) {
     } else {
 
       columns.forEach((x) => {
-        let col_idx = columns.indexOf(x);
+        let col_idx = in_data.columns.indexOf(x);
         column_index.push(col_idx);
       });
     }

danfojs-node/dist/core/get_dummies.js

@@ -74,7 +74,7 @@ function get_dummy(kwargs = {}) {
       });
     } else {
       columns.forEach(x => {
-        let col_idx = columns.indexOf(x);
+        let col_idx = in_data.columns.indexOf(x);
         column_index.push(col_idx);
       });
     }

danfojs-node/src/core/get_dummies.js

@@ -77,7 +77,7 @@ function get_dummy(kwargs = {}) {
     } else {
 
       columns.forEach((x) => {
-        let col_idx = columns.indexOf(x);
+        let col_idx = in_data.columns.indexOf(x);
         column_index.push(col_idx);
       });
     }

danfojs-node/tests/core/get_dummies.js

@@ -149,6 +149,20 @@ describe("get_dummies", function(){
       "prefix for dataframe must be an array");
 
   });
+  it("should one hot encode all other columns", function(){
+
+    let data = [ [ 1, "dog", 1.0, "fat" ], [ 3, "fog", 2.0, "good" ], [ 4, "gof", 3.0, "best" ] ];
+    let columns = [ "A", "B", "C", "d" ];
+    let df = new DataFrame(data, { columns:columns });
+    let rslt = [
+      [ 1, 'dog', 1, 1, 0, 0 ],
+      [ 3, 'fog', 2, 0, 1, 0 ],
+      [ 4, 'gof', 3, 0, 0, 1 ]
+    ]
+
+    assert.deepEqual(get_dummies({ data:df, columns:[ "d" ]}).values, rslt)
+
+  });
 
 
 });