Skip to content

Fixed: Does df.fillNa() turn on { inplace: true } by default? #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fixed: Does df.fillNa() turn on { inplace: true } by default? #684

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 40 additions & 8 deletions src/danfojs-base/core/frame.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1779,6 +1779,30 @@ export default class DataFrame extends NDframe implements DataFrameInterface {
}
}

/**
* Creates a deep copy of values while preserving NaN values
* @param values The values to deep copy
* @returns A deep copy of the values with NaN preserved
*/
private $deepCopyValues(values: any): any {
if (values === null || typeof values !== 'object') {
return values;
}
if (values instanceof Date) {
return new Date(values.getTime());
}
if (Array.isArray(values)) {
return values.map(value => this.$deepCopyValues(value));
}
const result: any = {};
for (const key in values) {
if (Object.prototype.hasOwnProperty.call(values, key)) {
result[key] = this.$deepCopyValues(values[key]);
}
}
return result;
}

/**
* Generate descriptive statistics for all numeric columns.
* Descriptive statistics include those that summarize the central tendency,
Expand Down Expand Up @@ -2130,7 +2154,12 @@ export default class DataFrame extends NDframe implements DataFrameInterface {
if (!columns) {
//Fill all columns
for (let i = 0; i < oldValues.length; i++) {
const valueArr = [...oldValues[i] as ArrayType1D]
let valueArr = [];
if (inplace) {
valueArr = this.$deepCopyValues(oldValues[i]) as ArrayType1D;
} else {
valueArr = [...oldValues[i] as ArrayType1D];
}

const tempArr = valueArr.map((innerVal) => {
if (utils.isEmpty(innerVal)) {
Expand All @@ -2145,14 +2174,17 @@ export default class DataFrame extends NDframe implements DataFrameInterface {

} else {
//Fill specific columns
const tempData = [...this.values]

for (let i = 0; i < tempData.length; i++) {
const valueArr = tempData[i] as ArrayType1D
for (let i = 0; i < oldValues.length; i++) {
let valueArr = [];
if (inplace) {
valueArr = this.$deepCopyValues(oldValues[i]) as ArrayType1D;
} else {
valueArr = [...oldValues[i] as ArrayType1D];
}

for (let i = 0; i < columns.length; i++) { //B
const columnIndex = this.columns.indexOf(columns[i])
const replaceWith = Array.isArray(values) ? values[i] : values
for (let j = 0; j < columns.length; j++) {
const columnIndex = this.columns.indexOf(columns[j])
const replaceWith = Array.isArray(values) ? values[j] : values
valueArr[columnIndex] = utils.isEmpty(valueArr[columnIndex]) ? replaceWith : valueArr[columnIndex]
}
newData.push(valueArr)
Expand Down