Albs deploy fix 2 jh by javihernandez · Pull Request #9 · javihernandez/albs-web-server

javihernandez · 2024-02-28T12:28:30Z

No description provided.

packages_exporter.py now queries sign-file service for repomd.xml signing

…ency

- renamed attrs in config.py to make it same as in env.vars - fix using wrong attibute for sending file in aiohttp request (data instead of files)

Fixed some bugs

It`ll be safer to remove it after we swith to new logic

…s enviroment

* upstream/master: (62 commits) Revert "New modularity support after migration to new pulp" Fix 401 when click to the Advisory info Black syntax Ensure that OVAL data contains released records only Black syntax Rebased to latest migration in master Black/isort syntax Fix tests after new modularity workflow Update migration checks workflow to try merging if rebasing fails Update migration check workflow Adjust alembic migration after updating branch with current master Rebased to latest migration in master Fixed black warnings #2 Fixed black warnings Fixed tests #2 Fixed tests Fixed relationships problems Add ability to create same errata record for several platforms Update dependencies to mitigate security risks Black syntax ...

Some updates following review

It needs to be refactored.

github-actions · 2024-02-28T12:29:35Z

pylint output

************* Module tests.test_scripts.test_packages_exporter
tests/test_scripts/test_packages_exporter.py:1:0: C0114: Missing module docstring (missing-module-docstring)
tests/test_scripts/test_packages_exporter.py:15:0: C0116: Missing function or method docstring (missing-function-docstring)
tests/test_scripts/test_packages_exporter.py:23:19: E1120: No value for argument 'token' in method call (no-value-for-parameter)
************* Module alws.config
alws/config.py:1:0: C0114: Missing module docstring (missing-module-docstring)
alws/config.py:7:0: C0115: Missing class docstring (missing-class-docstring)
alws/config.py:76:4: C0116: Missing function or method docstring (missing-function-docstring)
alws/config.py:80:4: C0116: Missing function or method docstring (missing-function-docstring)
alws/config.py:87:4: C0116: Missing function or method docstring (missing-function-docstring)
************* Module scripts.packages_exporter
scripts/packages_exporter.py:425:0: C0301: Line too long (88/80) (line-too-long)
scripts/packages_exporter.py:1:0: C0302: Too many lines in module (1072/1000) (too-many-lines)
scripts/packages_exporter.py:392:5: W0511: TODO: Use direct function call to alws.crud.errata_get_oval_xml (fixme)
scripts/packages_exporter.py:1:0: C0114: Missing module docstring (missing-module-docstring)
scripts/packages_exporter.py:21:0: E0401: Unable to import 'rpm' (import-error)
scripts/packages_exporter.py:35:0: C0413: Import "from alws import database, models" should be placed at the top of the module (wrong-import-position)
scripts/packages_exporter.py:36:0: C0413: Import "from alws.config import settings" should be placed at the top of the module (wrong-import-position)
scripts/packages_exporter.py:37:0: C0413: Import "from alws.constants import SignStatusEnum" should be placed at the top of the module (wrong-import-position)
scripts/packages_exporter.py:38:0: C0413: Import "from alws.utils.errata import extract_errata_metadata, extract_errata_metadata_modern, find_metadata, generate_errata_page, iter_updateinfo, merge_errata_records, merge_errata_records_modern" should be placed at the top of the module (wrong-import-position)
scripts/packages_exporter.py:47:0: C0413: Import "from alws.utils.exporter import download_file, get_repodata_file_links" should be placed at the top of the module (wrong-import-position)
scripts/packages_exporter.py:48:0: C0413: Import "from alws.utils.osv import export_errata_to_osv" should be placed at the top of the module (wrong-import-position)
scripts/packages_exporter.py:49:0: C0413: Import "from alws.utils.pulp_client import PulpClient" should be placed at the top of the module (wrong-import-position)
scripts/packages_exporter.py:59:0: C0116: Missing function or method docstring (missing-function-docstring)
scripts/packages_exporter.py:148:0: C0116: Missing function or method docstring (missing-function-docstring)
scripts/packages_exporter.py:163:0: C0116: Missing function or method docstring (missing-function-docstring)
scripts/packages_exporter.py:177:0: C0116: Missing function or method docstring (missing-function-docstring)
scripts/packages_exporter.py:187:0: C0115: Missing class docstring (missing-class-docstring)
scripts/packages_exporter.py:187:0: R0902: Too many instance attributes (14/7) (too-many-instance-attributes)
scripts/packages_exporter.py:188:4: R0913: Too many arguments (8/5) (too-many-arguments)
scripts/packages_exporter.py:238:17: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
scripts/packages_exporter.py:242:4: C0116: Missing function or method docstring (missing-function-docstring)
scripts/packages_exporter.py:245:4: C0116: Missing function or method docstring (missing-function-docstring)
scripts/packages_exporter.py:269:4: C0116: Missing function or method docstring (missing-function-docstring)
scripts/packages_exporter.py:269:4: R0913: Too many arguments (8/5) (too-many-arguments)
scripts/packages_exporter.py:305:4: C0116: Missing function or method docstring (missing-function-docstring)
scripts/packages_exporter.py:369:4: C0116: Missing function or method docstring (missing-function-docstring)
scripts/packages_exporter.py:384:15: W0718: Catching too general exception Exception (broad-exception-caught)
scripts/packages_exporter.py:388:4: C0116: Missing function or method docstring (missing-function-docstring)
scripts/packages_exporter.py:393:4: C0116: Missing function or method docstring (missing-function-docstring)
scripts/packages_exporter.py:406:4: C0116: Missing function or method docstring (missing-function-docstring)
scripts/packages_exporter.py:426:12: C0103: Variable name "pubDate" doesn't conform to snake_case naming style (invalid-name)
scripts/packages_exporter.py:439:4: C0116: Missing function or method docstring (missing-function-docstring)
scripts/packages_exporter.py:458:15: W0718: Catching too general exception Exception (broad-exception-caught)
scripts/packages_exporter.py:492:15: W0718: Catching too general exception Exception (broad-exception-caught)
scripts/packages_exporter.py:497:4: C0116: Missing function or method docstring (missing-function-docstring)
scripts/packages_exporter.py:505:4: C0116: Missing function or method docstring (missing-function-docstring)
scripts/packages_exporter.py:527:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
scripts/packages_exporter.py:531:4: C0116: Missing function or method docstring (missing-function-docstring)
scripts/packages_exporter.py:531:4: R0914: Too many local variables (19/15) (too-many-locals)
scripts/packages_exporter.py:535:22: W0212: Access to a protected member _RPMVSF_NOSIGNATURES of a client class (protected-access)
scripts/packages_exporter.py:608:17: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
scripts/packages_exporter.py:531:4: R0915: Too many statements (54/50) (too-many-statements)
scripts/packages_exporter.py:613:4: C0116: Missing function or method docstring (missing-function-docstring)
scripts/packages_exporter.py:613:4: R0914: Too many local variables (17/15) (too-many-locals)
scripts/packages_exporter.py:679:4: C0116: Missing function or method docstring (missing-function-docstring)
scripts/packages_exporter.py:699:4: C0116: Missing function or method docstring (missing-function-docstring)
scripts/packages_exporter.py:773:4: C0116: Missing function or method docstring (missing-function-docstring)
scripts/packages_exporter.py:786:0: C0116: Missing function or method docstring (missing-function-docstring)
scripts/packages_exporter.py:786:0: R0914: Too many local variables (16/15) (too-many-locals)
scripts/packages_exporter.py:826:0: C0116: Missing function or method docstring (missing-function-docstring)
scripts/packages_exporter.py:849:0: C0116: Missing function or method docstring (missing-function-docstring)
scripts/packages_exporter.py:856:11: W0718: Catching too general exception Exception (broad-exception-caught)
scripts/packages_exporter.py:863:0: C0116: Missing function or method docstring (missing-function-docstring)
scripts/packages_exporter.py:863:0: R0914: Too many local variables (31/15) (too-many-locals)
scripts/packages_exporter.py:931:11: W0718: Catching too general exception Exception (broad-exception-caught)
scripts/packages_exporter.py:1060:15: W0718: Catching too general exception Exception (broad-exception-caught)
scripts/packages_exporter.py:1025:21: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
scripts/packages_exporter.py:1029:21: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
scripts/packages_exporter.py:1044:21: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
scripts/packages_exporter.py:1048:16: W1203: Use lazy % formatting in logging functions (logging-fstring-interpolation)
scripts/packages_exporter.py:1055:21: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
scripts/packages_exporter.py:1059:16: W1203: Use lazy % formatting in logging functions (logging-fstring-interpolation)
scripts/packages_exporter.py:863:0: R0912: Too many branches (20/12) (too-many-branches)
scripts/packages_exporter.py:863:0: R0915: Too many statements (91/50) (too-many-statements)

-----------------------------------
Your code has been rated at 8.66/10

github-actions · 2024-02-28T12:33:17Z

Coverage report for changed files •

File	Stmts	Miss	Cover	Missing
config.py	57	0	100%
TOTAL	9696	4229	56%

Tests	Skipped	Failures	Errors	Time
82	3 💤	0 ❌	0 🔥	41.454s ⏱️

maccelf and others added 29 commits December 15, 2023 12:33

ALBS-1067: Create microservice for file signing application

f867ce7

ALBS-1065: Remove file signing functionality from web server code

cd8b24a

Rebase of https://github.com/AlmaLinux/albs-web-server/tree/albs-986

700d3ae

Added sign-file to docker-compose and nginx config

5616d7c

packages_exporter.py now queries sign-file service for repomd.xml signing

Fixes build-system#150: for alts-scheduler added web-server as depend…

f7d0a30

…ency

Added log rotation for docker-compose (Patch from AlmaLinux#689)

712263a

build-system#148:

52602ae

- renamed attrs in config.py to make it same as in env.vars - fix using wrong attibute for sending file in aiohttp request (data instead of files)

Added test for packages_exporter`s new logic

f5dda8a

Fixed some bugs

Returned removed sign endpoints.

dd66080

It`ll be safer to remove it after we swith to new logic

Small fix to make tests_cacher work

de10172

Fix migrations-check.yml

498e04c

Fix for migrations-check.yml 2

e3e5726

Fix syntax.yml workflow

deaa4f3

Fix syntax.yml

43beafc

Fixes: AlmaLinux/build-system#148

0d5f396

Fixes 'AlmaLinux/build-system#148'

3d8c43c

Trying to fix pytest.yml

2e9f260

Trying to fix pytest.yml

3af46a7

Reverted back test changes

a7f92e9

Disabled test test_packages_exporter.py from running in Github Action…

a3005f6

…s enviroment

Debuging GH actions

10bd9e8

Debig GH Actions

b0513bf

Finished debbugging GH actions

9dee4f4

Fix styiling

0979636

Adjust sign_server_api_url default to work in dev env

a709934

Some updates following review

Adjust dependencies in docker-compose.yml

8a43f63

Skip packages_exporter test

4137110

It needs to be refactored.

Request albs_sign_file token only once

40ee23d

Do not set GITHUB_ACTIONS env var when running tests

08773cc

javihernandez force-pushed the albs-deploy-fix-2-jh branch from 0eafa50 to 08773cc Compare February 28, 2024 12:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Albs deploy fix 2 jh#9

Albs deploy fix 2 jh#9
javihernandez wants to merge 30 commits intomasterfrom
albs-deploy-fix-2-jh

javihernandez commented Feb 28, 2024

Uh oh!

github-actions bot commented Feb 28, 2024

Uh oh!

github-actions bot commented Feb 28, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

javihernandez commented Feb 28, 2024

Uh oh!

github-actions bot commented Feb 28, 2024

Uh oh!

github-actions bot commented Feb 28, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants