Skip to content

[Pallas:MGPU] Add ReducedLayout support to inline_mgpu params #32471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Pallas:MGPU] Add ReducedLayout support to inline_mgpu params #32471

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions jax/_src/pallas/mosaic_gpu/primitives.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@
Layout = gpu_core.Layout
ParameterizedLayout = gpu_core.ParameterizedLayout
SomeLayout = gpu_core.SomeLayout
ReducedLayout = gpu_core.ReducedLayout


def _check_ref(
Expand Down Expand Up @@ -2216,10 +2217,10 @@ def add_one(ctx, smem_ref):
raise ValueError(
"inline_mgpu_p only supports plgpu.ShapeDtypeStruct return types."
)
if not all(isinstance(r, (Layout, ParameterizedLayout, RefType)) for r in flat_arg_types):
if not all(isinstance(r, (Layout, ParameterizedLayout, ReducedLayout, RefType)) for r in flat_arg_types):
raise ValueError(
"inline_mgpu_p only supports only Layout, ParameterizedLayout and"
" RefType arg types."
"inline_mgpu_p only supports only Layout, ParameterizedLayout,"
" ReducedLayout and RefType arg types."
)

def inner(f):
Expand All @@ -2236,7 +2237,9 @@ def wrapper(*args):
if isinstance(a, state_types.TransformedRef) and isinstance(t, RefType):
raw_flat_args.append(a.ref)
ref_transforms.append(a.transforms)
elif isinstance(aval := jax_core.get_aval(a), jax_core.ShapedArray) and isinstance(t, (ParameterizedLayout, Layout)):
elif isinstance(
aval := jax_core.get_aval(a), jax_core.ShapedArray
) and isinstance(t, (ParameterizedLayout, Layout, ReducedLayout)):
raw_flat_args.append(a)
ref_transforms.append(None)
elif isinstance(aval, state.AbstractRef) and isinstance(t, RefType):
Expand Down Expand Up @@ -2313,7 +2316,11 @@ def _type_check_mgpu_lane_semantics(v, ty):
raise ValueError(
f"Array layout mismatch: expected {v.layout} got {ty.layout.to_mgpu()}."
)
case (Layout() , mgpu.FragmentedArray()) | (ParameterizedLayout(), mgpu.FragmentedArray()):
case (
(Layout(), mgpu.FragmentedArray())
| (ParameterizedLayout(), mgpu.FragmentedArray())
| (ReducedLayout(), mgpu.FragmentedArray())
):
if ty.to_mgpu() != v.layout:
raise ValueError(f"Unexpected layout for {v} (expected: {ty})")
case _:
Expand Down
Loading